Page MenuHomeFreeBSD

vm_map_protect.9: update after code changes
ClosedPublic

Authored by kib on Jan 23 2021, 8:21 PM.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kib requested review of this revision.Jan 23 2021, 8:21 PM
kib created this revision.
share/man/man9/vm_map_protect.9
55–56

I think it's fine to leave this as "sets". I assume you changed it because the function does not necessarily set both. Because it's entirely dependent on the function's arguments I think it's still reasonable to say sets. To me "may set" implies that vm_map_protect will itself decide if one/both will be set.

83

Perhaps "are not allowed to"?

As is (and before your change) it seems unclear to me whether this is something the caller must take care not to violate, or that the function disallows.

96

Maybe something like
"Also, any in-progress wiring operation on the map affecting the specified range will cause .Nm to sleep, waiting for completion"

114

"The map does not allow ..." I think is clearer

115

Drop If as above, "Both new protection and..."
Or maybe Both VM_MAP_PROTECT_SET_PROT and VM_MAP_PROTECT_SET_MAXPROT were ..."

kib marked 5 inline comments as done.

Handle Ed notes.

share/man/man9/vm_map_protect.9
86

"The operation"

I would change "is declined" to "will fail" and "the condition" to "this condition".

88

"a shared mapping"

"of a read-only file from read-only to read-write"

125

s/for backing/to back/

128

"... protection updates were requested"

129

"but the specified"

kib marked 5 inline comments as done.

Mark' notes.

This revision is now accepted and ready to land.Jan 25 2021, 9:29 PM
This revision was automatically updated to reflect the committed changes.