Page MenuHomeFreeBSD

nfs client: block vnode_pager_setsize() calls from nfscl_loadattrcache in nfs_write
ClosedPublic

Authored by kib on Jan 23 2021, 10:54 AM.

Details

Summary

Otherwise writing thread might wait on sbusy state of the pages which were busied by itself, similarly to nfs_read(). But also we need to clear NVNSETSZKSIP flag possibly set by ncl_pager_setsize(), to not undo extension done by write.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kib requested review of this revision.Jan 23 2021, 10:54 AM
kib created this revision.

I ran the 29 NFS tests I have with D28306.82766.diff. This was a 2 1/2 hour test.
No problems seen.

Looks fine to me, although I'll admit that I
do not really understand the vnode_pager_setsize()
stuff well enough to say whether or not this is correct?

This revision is now accepted and ready to land.Jan 23 2021, 2:49 PM