Page MenuHomeFreeBSD

ktls: Improve handling of the bind_threads tunable a bit
ClosedPublic

Authored by markj on Jan 14 2021, 4:36 PM.

Details

Summary
  • Only check for empty domains if we actually tried to configure domain affinity in the first place. Otherwise setting bind_threads=1 will always cause the sysctl value to be reported as zero. This is harmless since the threads end up being bound, but it's confusing.
  • Try to improve the sysctl description a bit.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj requested review of this revision.Jan 14 2021, 4:36 PM
This revision is now accepted and ready to land.Jan 14 2021, 6:14 PM

I saw this the other day and almost thought that we should have separate knobs for "bind threads to cores" and "bind sessions to NUMA domains" rather than have ktls_bind_threads serve as a kind of tri-state. However, I think this approach is fine.