Page MenuHomeFreeBSD

IGNOREFILES no longer exists, run-time brokenness should be BROKEN not IGNORE
ClosedPublic

Authored by antoine on Jun 24 2014, 12:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 6, 3:27 AM
Unknown Object (File)
Mon, Oct 6, 12:48 AM
Unknown Object (File)
Mon, Oct 6, 12:27 AM
Unknown Object (File)
Mon, Oct 6, 12:24 AM
Unknown Object (File)
Sun, Oct 5, 10:57 PM
Unknown Object (File)
Sun, Oct 5, 10:24 PM
Unknown Object (File)
Sun, Oct 5, 10:21 PM
Unknown Object (File)
Sun, Oct 5, 10:09 PM
Subscribers
None

Details

Reviewers
gjb
rene
wblock
mat
Summary

IGNOREFILES no longer exists, run-time brokenness should be BROKEN not IGNORE

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

antoine retitled this revision from to IGNOREFILES no longer exists, run-time brokenness should be BROKEN not IGNORE.
antoine updated this object.
antoine edited the test plan for this revision. (Show Details)
antoine added reviewers: mat, wblock, gjb, rene.
en_US.ISO8859-1/books/porters-handbook/porting-dads/chapter.xml
455

Mmmm, are you removing that to win an argument with danfe ? :-p

en_US.ISO8859-1/books/porters-handbook/porting-dads/chapter.xml
455

Yes, but because it is right too :-)

rene requested changes to this revision.Jun 24 2014, 12:14 PM
rene edited edge metadata.
rene added inline comments.
en_US.ISO8859-1/books/porters-handbook/porting-dads/chapter.xml
455

It would be nice to move this to the BROKEN list (around line 401) instead of just removing it.

While there, line 413 should probably mention PREFIX instead of LOCALBASE for correctness (although in practice they are often the same).

This revision now requires changes to proceed.Jun 24 2014, 12:14 PM
antoine edited edge metadata.

Try to take rene's comment in account

rene edited edge metadata.
This revision is now accepted and ready to land.Jun 24 2014, 12:42 PM
en_US.ISO8859-1/books/porters-handbook/porting-dads/chapter.xml
389

This should be expanded to include the runtime brokenishness bit.

antoine edited edge metadata.

Take a comment from mat in account

rene requested changes to this revision.Jun 24 2014, 12:59 PM
rene edited edge metadata.
rene added inline comments.
en_US.ISO8859-1/books/porters-handbook/porting-dads/chapter.xml
391

No serial comma here ...

393

Mixing whitespace changes with content changes here (whitespace fixes should be in a folllowup commit for translators).

This revision now requires changes to proceed.Jun 24 2014, 12:59 PM
en_US.ISO8859-1/books/porters-handbook/porting-dads/chapter.xml
391

What he means is that you should write compile, install, deinstall, or run

en_US.ISO8859-1/books/porters-handbook/porting-dads/chapter.xml
424

I think 'runtime' should be used instead of 'run-time.'

en_US.ISO8859-1/books/porters-handbook/porting-dads/chapter.xml
393

While that's true, it's only one line, I'm not sure it warrants having another commit just for it.

antoine edited edge metadata.

Add a comma, use runtime instead of run-time

en_US.ISO8859-1/books/porters-handbook/porting-dads/chapter.xml
393

It does, because "just one line" turns into "just two" or "just three" lines very quickly, and it makes the actual content change difficult to detect for translators.

antoine edited edge metadata.

Undo white space changes

rene edited edge metadata.
This revision is now accepted and ready to land.Jun 24 2014, 1:26 PM