Now that we are committing via git this incorrectly assigns the
subversion repository to all revision that are uploaded using
arcanist
This reverts commit 1906ce9ca7d8fb9bb130c075e466812c22f8fd47.
Differential D27972
Revert "arcconfig: add callsign again" arichardson on Jan 5 2021, 11:53 AM. Authored by Tags None Referenced Files
Subscribers
Details
Now that we are committing via git this incorrectly assigns the This reverts commit 1906ce9ca7d8fb9bb130c075e466812c22f8fd47.
Diff Detail
Event TimelineComment Actions I think I'd still rather fix the callsign. It would be '10' now I think (too bad we can't just rename the 'S' alias in phabricator itself). For example, in this checkout: > git status On branch main Your branch is up to date with 'origin/main'. > git remote -v freebsd https://git.freebsd.org/src.git (fetch) freebsd ssh://git@gitrepo.freebsd.org/src.git (push) origin git@github.com:bsdjhb/freebsd.git (fetch) origin git@github.com:bsdjhb/freebsd.git (push) If I remove the callsign, arc which says it can't figure out what to do: > arc which REPOSITORY To identify the repository associated with this working copy, arc followed this process: Configuration value "repository.callsign" is empty. This repository has no VCS UUID (this is normal for git/hg). The remote URI for this working copy is "git@github.com:bsdjhb/freebsd.git". No repositories matched the query. Check that your configuration is correct, or use "repository.callsign" to select a repository explicitly. This working copy is not associated with any repository. I tried using '10' and 'R10' as the callsign and neither of those worked: > arc which REPOSITORY To identify the repository associated with this working copy, arc followed this process: Configuration value "repository.callsign" is set to "R10". No repositories matched the query. Check that your configuration is correct, or use "repository.callsign" to select a repository explicitly. This working copy is not associated with any repository. We should figure out what the right fix is, but I think it will always require an explicit callsign as the implicit callsign depends on having a single source of truth, and we don't have that, we have git.freebsd.org, github/freebsd/freebsd-src.git, and a mirror on gitlab already. Comment Actions I think arcanist might not like numeric-only callsigns? I can't figure out what the correct value should be. Comment Actions Might be. I hope we can still using "S" as the callsign in the git repository, and rename the old svn repository. I'm back to work on testing this in phabricator staging env this week. Please wait me for a few days more. Comment Actions There is no good test result so far. I think it benefits anybody to keep blocking this. Let's remove the repository callsign first and we can add it back if it's needed in the future. |