Page MenuHomeFreeBSD

devel/libepoll-shim: update to 0.0.20201229
ClosedPublic

Authored by jbeich on Jan 5 2021, 1:20 AM.

Details

Summary

Take advantage of D26668. See changelog.

Test Plan
  • Builds fine on 11.4/12.1/12.2/13.0 amd64/i386, 12.2 aarch64, 13.0 aarc64/armv6/armv7
  • Runtime tested on Sway with Firefox + VAAPI and FreeRDP

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jbeich requested review of this revision.Jan 5 2021, 1:20 AM
bapt requested changes to this revision.Jan 5 2021, 10:10 AM
bapt added a subscriber: bapt.

Please use @comment instead of butchering the plist

This revision now requires changes to proceed.Jan 5 2021, 10:10 AM
manu added inline comments.
devel/libepoll-shim/Makefile
24 ↗(On Diff #81656)

Please use @comment and PLIST_SUB for this.

Which style do you prefer?

.if exists(/usr/include/sys/eventfd.h)
PLIST_SUB+=	SHIM_EVENTFD="@comment "
.else
PLIST_SUB+=	SHIM_EVENTFD=
.endif

versus

.if !exists(/usr/include/sys/eventfd.h)
PLIST_FILES+=	include/libepoll-shim/sys/eventfd.h
.endif

Note, it's possible to uglify further by introducing OSVERSION checks.

I prefer the first, thank you

  • Switch to PLIST_SUB as suggested by @manu
This revision is now accepted and ready to land.Jan 5 2021, 10:34 AM

I would have prefered the first solution that you posted TBH but ok.

This revision was automatically updated to reflect the committed changes.