Page MenuHomeFreeBSD
Differential D27965

devel/libepoll-shim: update to 0.0.20201229
ClosedPublic
Actions

Authored by jbeich on Jan 5 2021, 1:20 AM.
Tags
None
Referenced Files
F89290537: D27965.id81662.diff
Fri, Jul 26, 5:44 AM
Unknown Object (File)
Fri, Jul 12, 2:57 PM
Unknown Object (File)
Sat, Jun 29, 8:58 AM
Unknown Object (File)
Sat, Jun 29, 6:27 AM
Unknown Object (File)
Jun 23 2024, 3:25 AM
Unknown Object (File)
May 21 2024, 8:52 PM
Unknown Object (File)
May 21 2024, 8:52 PM
Unknown Object (File)
May 21 2024, 8:52 PM
View All 56 Files
Subscribers
bapt
manu
mat
val_packett.cool

Details

Reviewers
bapt
manu
Group Reviewers
x11
Commits
rP560401: devel/libepoll-shim: update to 0.0.20201229
Summary

Take advantage of D26668. See changelog.

Test Plan
  • Builds fine on 11.4/12.1/12.2/13.0 amd64/i386, 12.2 aarch64, 13.0 aarc64/armv6/armv7
  • Runtime tested on Sway with Firefox + VAAPI and FreeRDP

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jbeich created this revision.Jan 5 2021, 1:20 AM
Herald added a subscriber: mat. · View Herald TranscriptJan 5 2021, 1:20 AM
jbeich requested review of this revision.Jan 5 2021, 1:20 AM
Harbormaster completed remote builds in B35934: Diff 81656.Jan 5 2021, 1:20 AM
bapt requested changes to this revision.Jan 5 2021, 10:10 AM
bapt added a subscriber: bapt.

Please use @comment instead of butchering the plist

This revision now requires changes to proceed.Jan 5 2021, 10:10 AM
manu added a subscriber: manu.Jan 5 2021, 10:10 AM
manu added inline comments.
devel/libepoll-shim/Makefile
24 ↗(On Diff #81656)

Please use @comment and PLIST_SUB for this.

jbeich added a comment.Jan 5 2021, 10:22 AM

Which style do you prefer?

.if exists(/usr/include/sys/eventfd.h)
PLIST_SUB+=	SHIM_EVENTFD="@comment "
.else
PLIST_SUB+=	SHIM_EVENTFD=
.endif

versus

.if !exists(/usr/include/sys/eventfd.h)
PLIST_FILES+=	include/libepoll-shim/sys/eventfd.h
.endif

Note, it's possible to uglify further by introducing OSVERSION checks.

bapt added a comment.Jan 5 2021, 10:28 AM

I prefer the first, thank you

jbeich updated this revision to Diff 81662.Jan 5 2021, 10:28 AM
  • Switch to PLIST_SUB as suggested by @manu
Harbormaster completed remote builds in B35939: Diff 81662.Jan 5 2021, 10:28 AM
bapt accepted this revision.Jan 5 2021, 10:34 AM
This revision is now accepted and ready to land.Jan 5 2021, 10:34 AM
manu accepted this revision.Jan 5 2021, 11:03 AM

I would have prefered the first solution that you posted TBH but ok.

Closed by commit rP560401: devel/libepoll-shim: update to 0.0.20201229 (authored by jbeich). · Explain WhyJan 5 2021, 2:51 PM
This revision was automatically updated to reflect the committed changes.
jbeich added a commit: rP560401: devel/libepoll-shim: update to 0.0.20201229.

Revision Contents
Changeset List

PathSize
head/
devel/
libepoll-shim/
5 lines
6 lines
2 lines

Diff 81673

View Options

head/devel/libepoll-shim/Makefile

Loading...
View Options

head/devel/libepoll-shim/distinfo

Loading...
View Options

head/devel/libepoll-shim/pkg-plist

Loading...