Page MenuHomeFreeBSD

mail/mutt: Update to 2.0.4
ClosedPublic

Authored by otis on Jan 4 2021, 12:18 PM.

Details

Summary

Update to 2.0.4, a bugfix release.

And while here, also:

  • Fix building of documentation (--without-doc is explicitly needed when DOCS is off, otherwise it defaulted to on, causing documentation to be build regardless of DOCS setting.)
  • reformat Makefile according to portfmt and portclippy

PR: 252295
Submitted by: Derek Schrock <dereks@lifeofadishwasher.com>

One open concern is:
If DOCS is on, then the configure script uses:

  • lynx
  • w3m
  • elinks

in this particular order to distill html to text version of manual.
Right now, the port's Makefile sets the build dependency to www/lynx
deliberately. On my build system (it could as well concern many other users)
there is already elinks installed that could be used for this purpose.
Some other user(s) may have w3m installed and they do not need to have
another browser installed.

My thought was to enclose the particular BUILD_DEPEND line into
.if ... .endif block to check for ${LOCALBASE}/bin/elinks and/or
${LOCALBASE}/bin/w3m and if none of them is present, only then
use www/lynx as a fallback.

Some other porters stated that these .if blocks are ill-advised,
but by looking into various ports Makefiles, I can see that this
approach is quite widely used.

What are *your* thoughts about this?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

otis requested review of this revision.Jan 4 2021, 12:18 PM

When setting the docs' html convert I chose lynx since it had the most overlapping depends with default mutt and built times. At the time that was www/lynx. Also assuming you're using poudriere to build so existing system checks aren't relevant there.

When possible I try to avoid non-framework functionality like what you're asking here so I'm not completely in favor of adding it. If someone is worried about extra packages being installed then a simple post build cleanup can be ran with pkg-autoremove?

It seems this might be better if we move MUTT_WWW?=lynx:www/lynx to a var and you change it via make MUTT_WWW=elinks:www/elinks, or add MUTT_WWW=... to your env?

When setting the docs' html convert I chose lynx since it had the most overlapping depends with default mutt and built times. At the time that was www/lynx. Also assuming you're using poudriere to build so existing system checks aren't relevant there.

When possible I try to avoid non-framework functionality like what you're asking here so I'm not completely in favor of adding it. If someone is worried about extra packages being installed then a simple post build cleanup can be ran with pkg-autoremove?

It seems this might be better if we move MUTT_WWW?=lynx:www/lynx to a var and you change it via make MUTT_WWW=elinks:www/elinks, or add MUTT_WWW=... to your env?

OK, for now, having dependency on www/lynx seems sane.

This revision is now accepted and ready to land.Jan 12 2021, 3:11 PM
This revision was automatically updated to reflect the committed changes.