Page MenuHomeFreeBSD
Differential D27938

Fix vnode locking bug in fuse_vnop_copy_file_range
ClosedPublic
Actions

Authored by asomers on Jan 3 2021, 3:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 21, 9:35 AM
Unknown Object (File)
Tue, Apr 21, 7:46 AM
Unknown Object (File)
Mon, Apr 20, 3:51 AM
Unknown Object (File)
Sat, Apr 18, 6:16 AM
Unknown Object (File)
Thu, Apr 9, 3:22 PM
Unknown Object (File)
Wed, Apr 8, 10:40 PM
Unknown Object (File)
Wed, Apr 8, 2:18 AM
Unknown Object (File)
Mon, Apr 6, 12:51 PM
View All Files
Subscribers
imp

Details

Reviewers
cem
Commits
rG17a82e6af8e2: Fix vnode locking bug in fuse_vnop_copy_file_range
Summary

MFC-With: 92bbfe1f0d1f1c4436d1f064a16e5aaf682526ba

Test Plan

fusefs test suite with DEBUG_VFS_LOCKS

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers created this revision.Jan 3 2021, 3:32 AM
Herald added a subscriber: imp. · View Herald TranscriptJan 3 2021, 3:32 AM
asomers requested review of this revision.Jan 3 2021, 3:32 AM
Harbormaster completed remote builds in B35902: Diff 81568.Jan 3 2021, 3:32 AM
cem added inline comments.Jan 3 2021, 12:43 PM
sys/fs/fuse/fuse_vnops.c
685–726

Need goto unlock instead of return (err); to avoid leaking the locks, I think.

asomers updated this revision to Diff 81588.Jan 3 2021, 4:34 PM
  • Don't leak locks on fufh lookup failure
Harbormaster completed remote builds in B35911: Diff 81588.Jan 3 2021, 4:34 PM
cem accepted this revision.Jan 3 2021, 4:49 PM
This revision is now accepted and ready to land.Jan 3 2021, 4:49 PM
Closed by commit rG17a82e6af8e2: Fix vnode locking bug in fuse_vnop_copy_file_range (authored by asomers). · Explain WhyJan 3 2021, 6:20 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rG17a82e6af8e2: Fix vnode locking bug in fuse_vnop_copy_file_range.

Revision Contents
Changeset List

PathSize
sys/
fs/
fuse/
16 lines

Diff 81594

View Options

sys/fs/fuse/fuse_vnops.c

Loading...