Page MenuHomeFreeBSD

Require uint32_t alignment for ipfw_insn
ClosedPublic

Authored by arichardson on Jan 1 2021, 1:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 28, 3:06 PM
Unknown Object (File)
Sat, Mar 21, 2:16 PM
Unknown Object (File)
Mon, Mar 16, 1:14 AM
Unknown Object (File)
Sat, Mar 14, 4:25 PM
Unknown Object (File)
Fri, Mar 13, 4:21 AM
Unknown Object (File)
Tue, Mar 3, 10:42 AM
Unknown Object (File)
Tue, Mar 3, 10:30 AM
Unknown Object (File)
Mon, Mar 2, 9:55 PM
Subscribers

Details

Summary

There are many casts of this struct to uint32_t, so we also need to ensure
that it is sufficiently aligned to safely perform this cast on architectures
that don't allow unaligned accesses. This fixes lots of -Wcast-align warnings.

Test Plan

fixes lots of compiler warnings

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/netinet/ip_fw.h
342

This could be _Alignas(uint32_t) with C11, but if we fall back to attribute((aligned)), we need an integer and can't use a type name.

This revision is now accepted and ready to land.Jan 19 2021, 10:24 AM

I have some doubts, that this change is safe. But probably we will see the result quickly.

This revision was automatically updated to reflect the committed changes.