Page MenuHomeFreeBSD

[vale] Fix valectl to compile on a 32-bit platform
ClosedPublic

Authored by adrian on Dec 29 2020, 6:26 PM.

Details

Summary

This shows up when compiling valectl on a 32 bit platform like i386 and mips32.
gcc-6.4 complains about this.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision is now accepted and ready to land.Dec 29 2020, 8:58 PM

ryan - I'll push this later today, but i figured you would want to see it as well :-)

LGTM. The same construct is seen in other assignments to pointers from nr_body.

I recommend putting the name of the warning you're solving in the commit log somewhere (-Wint-to-pointer-cast, right?).

The i386 kernel has a lot more of these due to PAE, but I haven't dug in to those.