net-mgmt/unifi6: Update to 6.0.43

[otis]

Summary

Update unifi controller software to version 6.0.43

• Improvements:
  • Disable ATF toggle for certain devices.
  • Add Advanced Feature Toggles, Data Rate Controls, MAC Authorisation in WiFi form.
  • Rename Client Groups to Bandwidth Profiles.
  • Display Site Switcher on Cloud Key with UniFi OS and multiple sites.
  • Add an option to download server log file in new Settings.

• Bugfixes:
  • Fix provisioning WLAN changes for USP-Plug & USP-Strip and their uplinks.
  • Fix adoption of USP-Plug & USP-Strip if user has separate 5GHz only WiFi.
  • Fix issues during migration if Site has incorrect config.
  • Fix Unknown device names in Cloud Emails.
  • Fix Firmware cache table columns and their height.
  • Fix overlapping column headers in Alert.
  • Fix alerts page crashing.
  • Fix event message rendering.
  • Fix historical U-LTE data stat processing.
  • Fix loading translations while using CORS.
  • Fix models names for APs.
  • Fix list of available backups to restore during the Setup of controller.
  • Fix headings for UDM and UBB radio details.
  • Fix blinking ports on UDM icon on Dashboard.
  • Fix blinking IPs and text messages.
  • Display Meshing settings only for last of 5GHz radios.
  • Disable Bluetooth after Setup is completed on UDM-Pro.
  • Resolve UCK-G2 identification issues.
  • Migrate minimum RSSI settings to new range (from -67 to -90 dBm).
  • Update minimum RSSI radio range in slider.
  • Update UI for WiFi form Advanced section.
  • Prevent deletion of WAN2 network on UXG-Pro.

Full changelog:
https://community.ui.com/releases/UniFi-Network-Controller-6-0-43/b28bb453-927a-4dd8-82f7-40af28505510

[osa]

Looks good to me, however it's unclear why some variables need to be prefixed with an underscore symbol. Hope it's possible to mention that in a commit log message.

[otis]

In D27802#621451, @osa wrote:

Looks good to me, however it's unclear why some variables need to be prefixed with an underscore symbol. Hope it's possible to mention that in a commit log message.

It only was to make portclippy happy and not whine about unknown variables.

[osa]

That looks pretty reasonable, would be great to add something like "Make portclippy(1) happy or more happy." - just to better understand why those variables have been prefixed.

[otis]

In D27802#621498, @osa wrote:

That looks pretty reasonable, would be great to add something like "Make portclippy(1) happy or more happy." - just to better understand why those variables have been prefixed.

Sure, this will be added to the final commit message.

And while here, also reformat Makefile a bit according to portfmt and portclippy.

[osa]

Looks good.

[otis]

Change one occurence of ${CP} to ${INSTALL_DATA}

[osa]

Looks good to me, please do not forget to update the commit message, thanks.