Page MenuHomeFreeBSD

devel/raylib: Install missing header files
ClosedPublic

Authored by otis on Dec 26 2020, 5:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 6:53 PM
Unknown Object (File)
Fri, May 3, 8:14 AM
Unknown Object (File)
Sun, Apr 21, 7:33 PM
Unknown Object (File)
Mar 26 2024, 7:09 PM
Unknown Object (File)
Feb 18 2024, 8:58 AM
Unknown Object (File)
Feb 9 2024, 10:44 AM
Unknown Object (File)
Jan 27 2024, 3:59 AM
Unknown Object (File)
Jan 20 2024, 9:23 AM
Subscribers

Details

Summary

It has been noticed that this port does not install some of the crucial header
files, this is also confirmed by the plist. The missing headers are from what I
can gather:

  • raymath.h
  • rlgl.h
  • physac.h

Along with corrected plist, also PORTREVISION has been bumped.

PR: 251819
Reported by: Mattias Wikstrom <burke@yagrebu.net>
Submitted by: Martin Filla <freebsd@sysctl.cz> (maintainer)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

otis requested review of this revision.Dec 26 2020, 5:27 PM
osa requested changes to this revision.Dec 26 2020, 6:45 PM

The patch looks good and I'd recommend to use ${INSTALL_DATA} instead of ${CP} command in the pre-install target.

This revision now requires changes to proceed.Dec 26 2020, 6:45 PM
In D27776#620799, @osa wrote:

The patch looks good and I'd recommend to use ${INSTALL_DATA} instead of ${CP} command in the pre-install target.

I've already had ${INSTALL_DATA} in consideration but dropped that for unknown reasons.
The other thing is that the pre-install target could/shout be moved to post-install (to let the respective make install begin in clean stage directory, not polluted with these three .h files).

Other than that I will also run a poudriere job for this (I did not do the tests myself at the moment, only the maintainer has been asked to do so).

Replace ${CP} with ${INSTALL_DATA} and move pre-install to post-install to let install target begin with clean stage directory.

This revision is now accepted and ready to land.Dec 28 2020, 9:24 AM
This revision was automatically updated to reflect the committed changes.