Differential D27733

add a description for the new tlscertname NFS mount option
ClosedPublic
Actions

Authored by rmacklem on Dec 22 2020, 11:15 PM.

Details

Reviewers

0mp

Group Reviewers

manpages

Commits

rG79302a6304b1: mount_nfs(8): add a description for the new "tlscertname" option

Summary

A patch that will be committed to head soon adds a
new NFS mount option called "tlscertname" which
specifies a non-default certificate to be provided
to the server during TLS handshake.

This patch adds a description of this option to the
man page.

Test Plan

mandoc does not seem to complain about it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rmacklem created this revision.Dec 22 2020, 11:15 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 22 2020, 11:15 PM

rmacklem requested review of this revision.Dec 22 2020, 11:15 PM

Harbormaster completed remote builds in B35634: Diff 81079.Dec 22 2020, 11:15 PM

A couple of mdoc suggestions. Otherwise, it seems fine!

sbin/mount_nfs/mount_nfs.8
429
434
442
450	Just a suggestion: I am not sure but it sounds a bit better to me, but I'm not a native speaker :)

Made the recommended changes.
I'll admit I started with .Ar and then changed to .Dq
because a plain text screen like I use does not mark
.Ar in any way.

However, you are correct that it should be .Ar name.

Thanks for looking at this, rick.

Harbormaster completed remote builds in B35636: Diff 81081.Dec 23 2020, 12:15 AM

Marked inline comments as done.

In D27733#619922, @rmacklem wrote:

Made the recommended changes.
I'll admit I started with .Ar and then changed to .Dq
because a plain text screen like I use does not mark
.Ar in any way.

However, you are correct that it should be .Ar name.

Ach, yes, that's unfortunate.

I think it's ready to ship! :))))

This revision is now accepted and ready to land.Dec 23 2020, 12:23 AM

Closed by commit rG79302a6304b1: mount_nfs(8): add a description for the new "tlscertname" option (authored by rmacklem). · Explain WhyDec 24 2020, 10:24 PM

This revision was automatically updated to reflect the committed changes.

rmacklem added a commit: rG79302a6304b1: mount_nfs(8): add a description for the new "tlscertname" option.