Page MenuHomeFreeBSD
Differential D27712

mk: Set the DIR tags based on the files one
ClosedPublic
Actions

Authored by manu on Dec 21 2020, 10:58 PM.

Details

Reviewers
bapt
Group Reviewers
pkgbase
Commits
R10:735a585e80b9: mk: Set the DIR tags based on the files one
Summary

Otherwise we loose the info as we use bsd.dirs.mk for creating directories.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

manu created this revision.Dec 21 2020, 10:58 PM
Herald added subscribers: emaste, bdrewery. · View Herald TranscriptDec 21 2020, 10:58 PM
manu requested review of this revision.Dec 21 2020, 10:58 PM
emaste added a comment.Dec 30 2020, 9:48 PM

Where does this get used?

manu added a comment.Dec 31 2020, 10:29 AM
In D27712#622400, @emaste wrote:

Where does this get used?

In any makefile that uses some FILESGROUP (usr.sbin/kyua was my main test case).

emaste added a comment.Dec 31 2020, 2:57 PM

Ah, thanks. It's still not immediately clear to me how the new variable gets used, e.g. when (based on the kyua example) DOCSDIRTAGS is now set

manu added a comment.Dec 31 2020, 3:28 PM
In D27712#622673, @emaste wrote:

Ah, thanks. It's still not immediately clear to me how the new variable gets used, e.g. when (based on the kyua example) DOCSDIRTAGS is now set

Yeah, it wasn't exactly clear to me at first what was the problem :)

bapt accepted this revision.Jan 4 2021, 1:28 PM
This revision is now accepted and ready to land.Jan 4 2021, 1:28 PM
Closed by commit R10:735a585e80b9: mk: Set the DIR tags based on the files one (authored by manu). · Explain WhyJan 4 2021, 3:26 PM
This revision was automatically updated to reflect the committed changes.
manu added a commit: R10:735a585e80b9: mk: Set the DIR tags based on the files one.

Revision Contents
Changeset List

PathSize
share/
mk/
2 lines

Diff 81621

View Options

share/mk/bsd.files.mk

Loading...