Page MenuHomeFreeBSD
Differential D27655

linuxkpi: Add sort function
AbandonedPublic
Actions

Authored by manu on Dec 17 2020, 3:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 7:36 AM
Unknown Object (File)
Dec 12 2023, 4:29 PM
Unknown Object (File)
May 14 2023, 7:02 PM
Unknown Object (File)
Apr 26 2023, 4:02 AM
Subscribers
emaste
imp
wulf

Details

Reviewers
None
Group Reviewers
linuxkpi
Summary

Add sort function.
Obtain from drmkpi/drm2

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

manu created this revision.Dec 17 2020, 3:36 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptDec 17 2020, 3:36 PM
manu requested review of this revision.Dec 17 2020, 3:36 PM
emaste added a comment.Dec 17 2020, 3:44 PM

Can we not use qsort from libkern?

sys/compat/linuxkpi/common/src/linux_sort.c
13

Can use 3. here. If this is modified from a userland copy we could update it to 3. also.

manu added a comment.Dec 17 2020, 3:55 PM
In D27655#618025, @emaste wrote:

Can we not use qsort from libkern?

qsort have it's own swap function and cannot be defined, but I guess I can make a new one in libkern that can use a defined swap func.

sys/compat/linuxkpi/common/src/linux_sort.c
13

I need to see from where it really was copied from but yeah something is weird here.

manu abandoned this revision.Aug 16 2022, 9:02 AM
manu added a subscriber: wulf.

@wulf commited a different version in 7356f661e81d1ff88bdb4daa127f3bfa2be7ecb9

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
40 lines
src/
181 lines
conf/
2 lines
modules/
linuxkpi/
1 line

Diff 80832

View Options

sys/compat/linuxkpi/common/include/linux/sort.h

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_sort.c

Loading...
View Options

sys/conf/files

Loading...
View Options

sys/modules/linuxkpi/Makefile

Loading...