Page MenuHomeFreeBSD
Differential D27615

pci_iov: When pci_iov_detach(9) is called, destroy VF children
ClosedPublic
Actions

Authored by kib on Dec 15 2020, 1:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 1, 6:37 AM
Unknown Object (File)
Mon, Jul 1, 6:29 AM
Unknown Object (File)
Mon, Jul 1, 2:26 AM
Unknown Object (File)
Mon, Jun 24, 12:35 PM
Unknown Object (File)
Wed, Jun 12, 10:07 PM
Unknown Object (File)
Apr 29 2024, 9:18 PM
Unknown Object (File)
Apr 29 2024, 8:11 PM
Unknown Object (File)
Apr 12 2024, 3:23 AM
View All 47 Files
Subscribers
imp
menyy_mellanox.com

Details

Reviewers
• hselasky
jhb
rstone
Commits
rS368749: pci_iov: When pci_iov_detach(9) is called, destroy VF children
Summary

instead of bailing out with EBUSY if there are any.

If driver module is unloaded, or just device is forcibly detached from the driver, there is no way for driver to correctly unload otherwise. Esp. if there are resources dedicated to the VFs which prevent turning down other resources.

Sponsored by: Mellanox Technologies / NVidia Networking

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Dec 15 2020, 1:57 AM
Herald added a subscriber: imp. · View Herald TranscriptDec 15 2020, 1:57 AM
kib requested review of this revision.Dec 15 2020, 1:57 AM
Harbormaster completed remote builds in B35407: Diff 80708.Dec 15 2020, 1:57 AM
jhb accepted this revision.Dec 17 2020, 5:16 PM
jhb added inline comments.
sys/dev/pci/pci_iov.c
98 ↗(On Diff #80708)

I would call it "children" rather than "childs".

This revision is now accepted and ready to land.Dec 17 2020, 5:16 PM
kib updated this revision to Diff 80849.Dec 17 2020, 7:05 PM
kib marked an inline comment as done.

s/childs/children/g

This revision now requires review to proceed.Dec 17 2020, 7:05 PM
Harbormaster completed remote builds in B35489: Diff 80849.Dec 17 2020, 7:05 PM
jhb accepted this revision.Dec 17 2020, 7:07 PM
This revision is now accepted and ready to land.Dec 17 2020, 7:07 PM
Closed by commit rS368749: pci_iov: When pci_iov_detach(9) is called, destroy VF children (authored by kib). · Explain WhyDec 18 2020, 3:47 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rS368749: pci_iov: When pci_iov_detach(9) is called, destroy VF children.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
pci/
53 lines

Diff 80879

View Options

head/sys/dev/pci/pci_iov.c

Loading...