Page MenuHomeFreeBSD

devel/tailor: Re-add port and update to 0.9.36
ClosedPublic

Authored by rhurlin on Dec 12 2020, 7:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 4:13 AM
Unknown Object (File)
Jan 11 2024, 5:18 AM
Unknown Object (File)
Dec 26 2023, 5:44 AM
Unknown Object (File)
Dec 20 2023, 4:16 AM
Unknown Object (File)
Dec 12 2023, 4:46 AM
Unknown Object (File)
Dec 7 2023, 2:45 AM
Unknown Object (File)
Nov 28 2023, 9:46 PM
Unknown Object (File)
Nov 28 2023, 3:18 AM

Details

Summary

Re-add expired port and update from 0.9.35 to 0.9.36. Use Python 3.7+ now.

Submitted by Chris Hutchinson <portmaster@bsdforge.com> (maintainer) in PR 251777.

In addition to the maintainer's patch, there are the following changes:
  • USES=python:3.7+ instead of python:3.7
  • Add USE_PYTHON=autoplist and PORTDOCS=README.* instead of pkg-plist
  • Add files/patch-vcpx_tailor.py to change version

Testet on Poudriere (amd64, i386). 'portlint -AC' is ok.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 35411
Build 32325: arc lint + arc unit

Event Timeline

LGTM
I'm embarrassed I forgot MOVED, as well as *version* in vcpx_tailor.py.

Thanks for taking the time to do this, Rainer. Really appreciate it.
Sorry for the bother.

This revision is now accepted and ready to land.Dec 12 2020, 8:15 PM

Wait a minute. I should really fix the version in the source itself (vcpx_tailor.py).
Can you pull that patch from this differential, and I'll submit the correct diff to the pr.
Or is there a better way, like make all these proposed changes to the pr this differential references?
Sorry. I have limited experience with these differentials, and the preferred procedure.

Wait a minute. I should really fix the version in the source itself (vcpx_tailor.py).
Can you pull that patch from this differential, and I'll submit the correct diff to the pr.

I am not sure, if I understand you right. The complete diff of this review as a raw file is available via differential.

Or is there a better way, like make all these proposed changes to the pr this differential references?

If you will update the version in vcpx/tailor.py, I will create an updated patch for this review. You do not have to do it :)

Sorry. I have limited experience with these differentials, and the preferred procedure.

No problem. It is only necessary to give me an updated download address for your sources of tailor on BSDforge. BTW, is there any changelog for tailor?

@tcberner I thought I followed this article. What exactly is the problem here? Do you mean the addport script (from the tip)? I didn't use it and made all manually.

OK I have a proper diff that makes all the necessary corrections. I went to attach it
to this differential, and submit took me to a different differential. I'm unclear how
anyone gets along here.
I'll try to attach it again.

OK I'm a reasonably intelligent individual. But the software used
for this appears to me to be fairly clueless. In my attempt to
update this differential with a newer diff. It created:
https://reviews.freebsd.org/D27593
Sorry. I simply followed the direction this software took me.

@tcberner I thought I followed this article. What exactly is the problem here? Do you mean the addport script (from the tip)? I didn't use it and made all manually.

Nono, I did not find a problem, that was just a general pointer -- if you already followed it, then awesome :)

Renew patch with dependencies and distinfo.

  • Author fixed runtime error and version in vcpx/tailor.py
  • Add devel/py-future as dependency
This revision now requires review to proceed.Dec 15 2020, 9:54 AM
This revision is now accepted and ready to land.Dec 15 2020, 10:20 AM

Committed in r558151. For some reason Phabricator get not closed 'automatically'.