Page MenuHomeFreeBSD
Differential D27568

Install missing calendar test files
ClosedPublic
Actions

Authored by arichardson on Dec 11 2020, 11:31 AM.
Tags
None
Referenced Files
F142835873: D27568.id80581.diff
Sat, Jan 24, 1:04 AM
Unknown Object (File)
Mon, Jan 19, 7:21 PM
Unknown Object (File)
Wed, Dec 31, 9:23 PM
Unknown Object (File)
Dec 6 2025, 12:29 AM
Unknown Object (File)
Nov 21 2025, 12:27 AM
Unknown Object (File)
Nov 21 2025, 12:25 AM
Unknown Object (File)
Nov 21 2025, 12:24 AM
Unknown Object (File)
Nov 21 2025, 12:20 AM
View All 88 Files
Subscribers
imp
lwhsu

Details

Reviewers
se
Commits
rS368551: Install 2 forgotten shell scripts required to run the tests
Summary

These files were not installed in r367350, so the testsuite has been
failing since then. I noticed this while comparing looking at the CheriBSD
test results and saw that these two tests were also failing upstream.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arichardson created this revision.Dec 11 2020, 11:31 AM
Herald added a subscriber: imp. · View Herald TranscriptDec 11 2020, 11:31 AM
arichardson requested review of this revision.Dec 11 2020, 11:31 AM
Harbormaster completed remote builds in B35340: Diff 80577.Dec 11 2020, 11:31 AM
arichardson added a comment.Dec 11 2020, 11:33 AM

First CI failure is here: https://ci.freebsd.org/job/FreeBSD-head-amd64-test/17072/testReport/

This revision was not accepted when it landed; it landed in state Needs Review.Dec 11 2020, 1:24 PM
Closed by commit rS368551: Install 2 forgotten shell scripts required to run the tests (authored by se). · Explain Why
This revision was automatically updated to reflect the committed changes.
se added a commit: rS368551: Install 2 forgotten shell scripts required to run the tests.
arichardson added a comment.Dec 11 2020, 1:28 PM

FYI, I have commit access and could have committed this myself.

se added a comment.Dec 11 2020, 1:29 PM

Thank you for the report and sorry for the breakage - is there a mail list that reports new test failures?

The files existed on my development system since I had developed the tests within /usr/tests and then created the tests/Makefile.
I should have wiped out the calendar tests and verified that they are correctly installed by installworld ...

The patch you supplied with this review has been committed.

arichardson added a subscriber: lwhsu.Dec 11 2020, 1:30 PM
In D27568#616081, @se wrote:

Thank you for the report and sorry for the breakage - is there a mail list that reports new test failures?

The files existed on my development system since I had developed the tests within /usr/tests and then created the tests/Makefile.
I should have wiped out the calendar tests and verified that they are correctly installed by installworld ...

The patch you supplied with this review has been committed.

I only get emails if one of my commits breaks the build. I don't think test suite regressions are reported. But I could be wrong. @lwhsu is there a list that reports test job regressions?

se added a comment.Dec 11 2020, 1:33 PM
In D27568#616080, @arichardson wrote:

FYI, I have commit access and could have committed this myself.

Yes, sorry, after testing that the file list in the Makefile was now complete, I committed your patch to get this fixed without further delay.
But I should have assumed that you were able to do it without much delay, too.
I'll just accept the review and let you do the commit, next time ...

Revision Contents
Changeset List

PathSize
head/
usr.bin/
calendar/
tests/
2 lines

Diff 80581

View Options

head/usr.bin/calendar/tests/Makefile

Loading...