amdsmn,amdtemp: add support for Family 19h (Zen 3)

[val_packett.cool]

Summary

• Zen 3 "Vermeer" support tested on Ryzen 9 5950X :)
• model numbers from https://en.wikichip.org/wiki/amd/cpuid "Extended Model" column — seems accurate, matches what was in the driver already

[cem]

Thanks for adding the new hardware. Seems like a reasonable approach to me.

sys/dev/amdsmn/amdsmn.c

62

Please be explicit about which 19h model numbers you're sure use the Starship/Matisse Root Complex.

sys/dev/amdtemp/amdtemp.c

813–826

Please make this change separate from refactoring this region so it's clear there is a change here.

[val_packett.cool]

sys/dev/amdsmn/amdsmn.c

62

Ah, sorry this was not obvious – there won't be model numbers in 19h, at least based on the constant naming here:

https://lkml.org/lkml/2020/1/9/1131

sys/dev/amdtemp/amdtemp.c

813–826

You could do that while committing..

[val_packett.cool]

sys/dev/amdsmn/amdsmn.c

62

(I mean "different PCIe IDs per model number", also https://github.com/torvalds/linux/blob/master/arch/x86/kernel/amd_nb.c note no new 19h constant for the root)

[cem]

sys/dev/amdsmn/amdsmn.c

62

The model number is a function of the CPUID. Please provide explicit model number ranges we know work with the device. That could be all current Zen 3 model numbers. For example, in the sensors CCD function, you added the M00H and M20H model families.

sys/dev/amdtemp/amdtemp.c

813–826

Please make the change.

[cem]

Thanks!