Page MenuHomeFreeBSD

amdsmn,amdtemp: add support for Family 19h (Zen 3)
ClosedPublic

Authored by greg_unrelenting.technology on Dec 10 2020, 7:13 PM.

Details

Summary
  • Zen 3 "Vermeer" support tested on Ryzen 9 5950X :)
  • model numbers from https://en.wikichip.org/wiki/amd/cpuid "Extended Model" column — seems accurate, matches what was in the driver already

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Thanks for adding the new hardware. Seems like a reasonable approach to me.

sys/dev/amdsmn/amdsmn.c
62 ↗(On Diff #80544)

Please be explicit about which 19h model numbers you're sure use the Starship/Matisse Root Complex.

sys/dev/amdtemp/amdtemp.c
813–826 ↗(On Diff #80544)

Please make this change separate from refactoring this region so it's clear there is a change here.

sys/dev/amdsmn/amdsmn.c
62 ↗(On Diff #80544)

Ah, sorry this was not obvious – there won't be model numbers in 19h, at least based on the constant naming here:

https://lkml.org/lkml/2020/1/9/1131

sys/dev/amdtemp/amdtemp.c
813–826 ↗(On Diff #80544)

You could do that while committing..

sys/dev/amdsmn/amdsmn.c
62 ↗(On Diff #80544)

(I mean "different PCIe IDs per model number", also https://github.com/torvalds/linux/blob/master/arch/x86/kernel/amd_nb.c note no new 19h constant for the root)

cem requested changes to this revision.Dec 11 2020, 7:30 PM
cem added inline comments.
sys/dev/amdsmn/amdsmn.c
62 ↗(On Diff #80544)

The model number is a function of the CPUID. Please provide explicit model number ranges we know work with the device. That could be all current Zen 3 model numbers. For example, in the sensors CCD function, you added the M00H and M20H model families.

sys/dev/amdtemp/amdtemp.c
813–826 ↗(On Diff #80544)

Please make the change.

This revision now requires changes to proceed.Dec 11 2020, 7:30 PM
greg_unrelenting.technology retitled this revision from amdsmn,amdtemp: add support for Family 19h (Zen 3), add forgotten Zen 2 APUs to amdsmn,amdtemp: add support for Family 19h (Zen 3).
greg_unrelenting.technology edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Dec 12 2020, 6:52 PM