Page MenuHomeFreeBSD

add new port: accessibility/gammy as alternative to accessibility/redshift
ClosedPublic

Authored by me_igalic.co on Dec 3 2020, 6:16 PM.

Details

Summary

This patch adds a new port accessibility/gammy; it's an alternative to accessibility/redshift that unlike redshift seems to work on my system without too much additional manual work

Test Plan

make
install
try

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

is there a way to make this easier searchable? should i mention "redshift"?

result of portlint -CANv:

OK: config: portsdir: "/usr/ports" rcsidstr: "FreeBSD" localbase: /usr/local 
OK: makevar: PORTNAME = gammy
OK: makevar: PORTVERSION = 0.9.59
OK: makevar: PORTREVISION = 0
OK: makevar: PORTEPOCH = 0
OK: makevar: PKGNAME = gammy-0.9.59
OK: makevar: PKGNAMEPREFIX = 
OK: makevar: PKGNAMESUFFIX = 
OK: makevar: DISTVERSIONPREFIX = v
OK: makevar: DISTVERSION = 0.9.59
OK: makevar: DISTVERSIONSUFFIX = 
OK: makevar: DISTNAME = Fushko-gammy-v0.9.59_GH0
OK: makevar: DISTFILES = Fushko-gammy-v0.9.59_GH0.tar.gz
OK: makevar: CATEGORIES = accessibility
OK: makevar: MASTERDIR = /usr/ports/accessibility/gammy
OK: makevar: MAINTAINER = me@igalic.co
OK: makevar: MASTER_SITES = https://codeload.github.com/Fushko/gammy/tar.gz/v0.9.59?dummy=/
OK: makevar: WRKDIR = /usr/ports/accessibility/gammy/work
OK: makevar: WRKSRC = /usr/ports/accessibility/gammy/work/gammy-0.9.59
OK: makevar: NO_WRKSUBDIR = 
OK: makevar: SCRIPTDIR = /usr/ports/accessibility/gammy/scripts
OK: makevar: FILESDIR = /usr/ports/accessibility/gammy/files
OK: makevar: PKGDIR = /usr/ports/accessibility/gammy
OK: makevar: COMMENT = Adaptive screen brightness and temperature for Windows and Unix
OK: makevar: DESCR = /usr/ports/accessibility/gammy/pkg-descr
OK: makevar: PLIST = /usr/ports/accessibility/gammy/pkg-plist
OK: makevar: PKGCATEGORY = accessibility
OK: makevar: PKGINSTALL = /usr/ports/accessibility/gammy/pkg-install
OK: makevar: PKGDEINSTALL = /usr/ports/accessibility/gammy/pkg-deinstall
OK: makevar: PKGREQ = 
OK: makevar: PKGMESSAGE = /usr/ports/accessibility/gammy/pkg-message
OK: makevar: DISTINFO_FILE = /usr/ports/accessibility/gammy/distinfo
OK: makevar: .CURDIR = /usr/ports/accessibility/gammy
OK: makevar: USE_LDCONFIG = 
OK: makevar: USE_AUTOTOOLS = 
OK: makevar: USE_GNOME = 
OK: makevar: USE_PERL5 = 
OK: makevar: USE_QT = core gui dbus widgets qmake_build buildtools_build qmake_build
OK: makevar: USE_QT5 = 
OK: makevar: INDEXFILE = INDEX-13
OK: makevar: PKGORIGIN = accessibility/gammy
OK: makevar: CONFLICTS = 
OK: makevar: PKG_VERSION = /usr/local/sbin/pkg-static version
OK: makevar: PLIST_FILES = bin/gammy /usr/local/share/licenses/gammy-0.9.59/catalog.mk  /usr/local/share/licenses/gammy-0.9.59/LICENSE /usr/local/share/licenses/gammy-0.9.59/GPLv3
OK: makevar: PLIST_DIRS = 
OK: makevar: PORTDOCS = 
OK: makevar: PORTEXAMPLES = 
OK: makevar: OPTIONS_DEFINE = 
OK: makevar: OPTIONS_RADIO = 
OK: makevar: OPTIONS_SINGLE = 
OK: makevar: OPTIONS_MULTI = 
OK: makevar: OPTIONS_GROUP = 
OK: makevar: OPTIONS_SUB = 
OK: makevar: INSTALLS_OMF = 
OK: makevar: USE_RC_SUBR = 
OK: makevar: USES = qmake qt:5 xorg gl xorg
OK: makevar: DIST_SUBDIR = 
OK: makevar: ALLFILES = Fushko-gammy-v0.9.59_GH0.tar.gz 
OK: makevar: CHECKSUM_ALGORITHMS = sha256
OK: makevar: INSTALLS_ICONS = 
OK: makevar: GNU_CONFIGURE = 
OK: makevar: CONFIGURE_ARGS = --with-qt-includes=/usr/local/include/qt5  --with-qt-libraries=/usr/local/lib/qt5  --with-extra-includes=/usr/local/include  --with-extra-libs=/usr/local/lib
OK: makevar: MASTER_SITE_SUBDIR = 
OK: makevar: LICENSE = GPLv3
OK: makevar: LICENSE_COMB = 
OK: makevar: NO_STAGE = 
OK: makevar: DEVELOPER = yes
OK: makevar: SUB_FILES = 
OK: makevar: SHEBANG_LANG = 
OK: makevar: MASTER_SITES_SUBDIRS = APACHE_COMMONS_BINARIES:gammy  APACHE_COMMONS_SOURCE:gammy  APACHE_JAKARTA:gammy/source  BERLIOS:gammy.berlios  CHEESESHOP:source/F/Fushko-gammy-v0.9.59_GH0  CRATESIO:gammy/v0.9.59  DEBIAN:pool/main/g/gammy  FARSIGHT:gammy  FESTIVAL:0.9.59  GCC:releases/Fushko-gammy-v0.9.59_GH0  GENTOO:distfiles  GIMP:gammy/0.9/  GITHUB:Fushko/gammy/tar.gz/v0.9.59?dummy=/  GITHUB_CLOUD:Fushko/gammy/  GNOME:sources/gammy/0.9  GNU:gammy  GNUPG:gammy  GNU_ALPHA:gammy  HORDE:gammy  LIBREOFFICE_DEV:gammy  MATE:0.9  MOZDEV:gammy  NETLIB:gammy  PERL_CPAN:gammy  QT:archive/qt/0.9  SAMBA:gammy  SAVANNAH:gammy  SOURCEFORGE:gammy/gammy/0.9.59  XFCE:xfce
OK: makevar: FLAVORS = 
OK: makevar: USE_PYTHON = 
OK: makevar: LICENSE_PERMS = 
OK: makevar: USE_PYQT = 
OK: makevar: USE_GITHUB = YES
OK: makevar: USE_GITLAB = 
OK: checking /usr/ports/accessibility/gammy/pkg-descr.
OK: /usr/ports/accessibility/gammy/pkg-descr: has 8 lines.
OK: checking Makefile.
OK: checking contiguous blank lines in Makefile.
OK: checking header in Makefile.
OK: checking for $(VARIABLE).
OK: checking for empty(${VARIABLE}).
OK: checking for use of !=.
OK: checking for use of .elseif.
OK: checking for use of muted INSTALL_ commands.
OK: checking for use of ${ENV} instead of ${SETENV}.
OK: checking for use of IGNOREFILES.
OK: checking for use of PLIST_DIRSTRY.
OK: checking PLIST_FILES and PLIST_DIRS.
OK: checking OPTIONS.
OK: checking DESKTOP_ENTRIES for ${TRUE}/${FALSE}.
OK: checking for USE_* as a user-settable option.
OK: checking for use of *_CMAKE_ARGS instead of *_CMAKE_ON|OFF.
OK: checking that *_CMAKE_BOOL only contains words.
OK: checking that *CMAKE* co-occurs with *USES+=cmake.
OK: checking NO_CHECKSUM.
OK: checking MACHINE_ARCH.
OK: checking DEPRECATED.
OK: checking IGNORE.
OK: checking BROKEN.
OK: checking COMMENT.
OK: checking FORBIDDEN.
OK: checking MANUAL_PACKAGE_BUILD.
OK: checking NO_CDROM.
OK: checking NO_PACKAGE.
OK: checking RESTRICTED.
OK: checking PKGNAME.
OK: checking for MAKE_JOBS_UNSAFE in combination with NO_BUILD.
OK: checking to see if certain macros are sorted.
OK: checking for USE_GNOME=pkgconfig.
OK: checking for valid EXPIRATION_DATE.
OK: checking IS_INTERACTIVE.
OK: checking for use of PORT_OPTIONS:MDOCS.
OK: checking for use of NOPORTDOCS.
OK: checking for use of NOPORTEXAMPLES.
OK: checking for use of NOPORTDOCS.
OK: checking for USES=gettext without PORT_OPTIONS:MNLS.
OK: checking for deprecated macros.
OK: checking for DOS line ending removal.
OK: checking direct use of command names.
OK: checking for paths that have macro replacements.
OK: checking for compression arguments passed to ${GZIP_CMD}.
OK: checking for ${CHMOD}.
OK: checking for ${INSTALL} -o | -g.
OK: checking for ${MKDIR} -p.
OK: checking for instances of ${FIND} ... ${XARGS} ${RM}.
OK: checking for instances of ${MACHINE_ARCH} being test.
OK: checking direct use of full pathnames in Makefile.
OK: checking direct use of pathnames, phase 1.
OK: checking direct use of pathnames, phase 2.
OK: checking direct use of pathnames, phase 1.
OK: checking direct use of pathnames, phase 2.
OK: checking direct use of pathnames, phase 1.
OK: checking direct use of pathnames, phase 2.
OK: checking direct use of pathnames, phase 1.
OK: checking direct use of pathnames, phase 2.
OK: checking direct use of pathnames, phase 1.
OK: checking direct use of pathnames, phase 2.
OK: checking direct use of pathnames, phase 1.
OK: checking direct use of pathnames, phase 2.
OK: checking direct use of pathnames, phase 1.
OK: checking direct use of pathnames, phase 2.
OK: checking direct use of pathnames, phase 1.
OK: checking direct use of pathnames, phase 2.
OK: checking direct use of pathnames, phase 1.
OK: checking direct use of pathnames, phase 2.
OK: checking direct use of pathnames, phase 1.
OK: checking direct use of pathnames, phase 2.
OK: checking direct use of pathnames, phase 1.
OK: checking direct use of pathnames, phase 2.
OK: checking direct use of pathnames, phase 1.
OK: checking direct use of pathnames, phase 2.
OK: checking direct use of pathnames, phase 1.
OK: checking direct use of pathnames, phase 2.
OK: checking direct use of pathnames, phase 1.
OK: checking direct use of pathnames, phase 2.
OK: checking direct use of pathnames, phase 1.
OK: checking direct use of pathnames, phase 2.
OK: checking direct use of pathnames, phase 1.
OK: checking direct use of pathnames, phase 2.
OK: checking direct use of pathnames, phase 1.
OK: checking direct use of pathnames, phase 2.
OK: checking direct use of pathnames, phase 1.
OK: checking direct use of pathnames, phase 2.
OK: checking SITE_PERL.
OK: non-slave port detected, checking for anything after bsd.port(.post).mk.
OK: checking comment section of Makefile.
OK: $FreeBSD$ seen in Makefile.
OK: checking first section of Makefile (PORTNAME/...).
OK: checking the order of PORTNAME section.
OK: seen PORTNAME, in order.
OK: seen PORTVERSION, in order.
OK: seen DISTVERSIONPREFIX, in order.
OK: seen CATEGORIES, in order.
OK: PORTNAME section is ordered properly.
OK: checking PORTNAME/PORTVERSION/DISTVERSION.
OK: checking for existence of PORTREVISION in new port.
OK: checking for existence of PORTEPOCH in new port.
OK: checking CATEGORIES.
OK: seen MASTER_SITES, sanity checking URLs.
OK: non-URL "accessibility" ok.
OK: no EXTRACT_SUFX seen, using default value.
OK: sanity checking PORTNAME/PORTVERSION/DISTVERSIONPREFIX/DISTVERSION/DISTVERSIONSUFFIX.
OK: PORTVERSION "0.9.59" looks fine.
OK: checking second section of Makefile (PATCH*: optional).
OK: checking third section of Makefile (MAINTAINER).
OK: checking items that have to appear earlier.
OK: checking the order of MAINTAINER section.
OK: seen MAINTAINER, in order.
OK: seen COMMENT, in order.
OK: MAINTAINER section is ordered properly.
OK: checking fourth section of Makefile (LICENSE).
OK: checking the order of LICENSE section.
OK: seen LICENSE, in order.
OK: LICENSE section is ordered properly.
OK: checking sixth section of Makefile (BROKEN/IGNORE/DEPRECATED).
OK: checking items that have to appear earlier.
OK: checking seventh section of Makefile (*_DEPENDS).
OK: checking items that have to appear earlier.
OK: check eighth section of Makefile (FLAVORS: optional).
OK: check ninth section of Makefile (USES: optional).
OK: checking items that have to appear earlier.
OK: seen USES.
OK: seen USE_QT.
OK: check if GH_ options are in use
OK: checking the rest of the Makefile.
OK: checking items that have to appear earlier.
OK: checking WRKSRC.
OK: WRKSRC seems to be ${WRKDIR}/.
OK: no NO_WRKSUBDIR, checking value of WRKSRC.
OK: checking RESTRICTED/NO_CDROM/NO_PACKAGE.
OK: checking INFO.
OK: checking /usr/ports/accessibility/gammy/distinfo.
OK: checking /usr/ports/MOVED.
OK: checking /usr/ports/UIDs.
OK: checking /usr/ports/GIDs.
OK: checking the file name of distinfo.
OK: checking the file name of gammylog.txt.
OK: checking the file name of Makefile.
OK: checking the file name of pkg-descr.
looks fine.

n.b.: my poudriere testport hasn't finished yet.

Moin moin

You're missing the SUBDIR entry in accessiblity/Makefile

mfg Tobias

accessibility/gammy/Makefile
13 ↗(On Diff #80273)

^ I would sort that alphabetically

14 ↗(On Diff #80273)

I normally group the USE_QT components as follows:

USE_QT= 		dbus core gui  widgets  \
                        buildtools_build qmake_build

(so group by kind, and sort alphabetically).

17 ↗(On Diff #80273)

no need to use +=, simply set

USE_XORG=x11 xxf86vm
accessibility/gammy/pkg-descr
3 ↗(On Diff #80273)

^ s/://g?

accessibility/gammy/Makefile
14 ↗(On Diff #80273)

core dbus... I know the alphabet :D

address (most of?) @tcberner's review

This revision was not accepted when it landed; it landed in state Needs Review.Dec 10 2020, 5:52 AM
This revision was automatically updated to reflect the committed changes.