Page MenuHomeFreeBSD

pf: Fix table entry counter toggling
ClosedPublic

Authored by markj on Dec 1 2020, 6:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 5:48 AM
Unknown Object (File)
Dec 20 2023, 12:47 AM
Unknown Object (File)
Sep 4 2023, 3:50 AM
Unknown Object (File)
Aug 18 2023, 5:06 AM
Unknown Object (File)
Jul 23 2023, 8:50 AM
Unknown Object (File)
May 1 2023, 8:44 AM
Unknown Object (File)
Dec 26 2022, 4:47 AM

Details

Summary

When updating a table, pf will keep table entry structures corresponding
to addresses that are in both of the old and new tables. However, the
update may also enable or disable per-entry counters which are allocated
separately. Thus when toggling PFR_TFLAG_COUNTERS, the entries may be
missing counters or may have unused counters allocated.

Fix the problem by modifying pfr_ina_commit() to transfer counters
from or to the shadow table.

Reported by: sigsys@gmail.com

Test Plan

Regression tests pass. I will write a test case for this if the code change seems ok.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable