Page MenuHomeFreeBSD
Differential D27385

iconv(1): Add EXAMPLE
ClosedPublic
Actions

Authored by fernape on Nov 26 2020, 6:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 4:54 AM
Unknown Object (File)
Wed, Jan 29, 10:47 AM
Unknown Object (File)
Tue, Jan 21, 8:07 AM
Unknown Object (File)
Sun, Jan 19, 1:57 PM
Unknown Object (File)
Jan 5 2025, 7:44 PM
Unknown Object (File)
Nov 3 2024, 8:19 PM
Unknown Object (File)
Oct 5 2024, 9:39 PM
Unknown Object (File)
Oct 2 2024, 8:34 AM
View All 46 Files
Subscribers
0mp
imp
Contributor Reviews (src)

Details

Reviewers
None
Group Reviewers
manpages
Commits
rS368244: iconv(1): Add EXAMPLE
rS368243: iconv(1): Add EXAMPLE
rS368160: iconv(1): Add EXAMPLE
Summary

Just a small example to show simple usage.

Test Plan
  • mandoc -Tlint clean
  • igor clean
  • aspell happy
  • man ./iconv.1 renders the page properly

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fernape created this revision.Nov 26 2020, 6:14 PM
Herald added a reviewer: manpages. · View Herald TranscriptNov 26 2020, 6:14 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
fernape requested review of this revision.Nov 26 2020, 6:14 PM
Harbormaster completed remote builds in B35054: Diff 80030.Nov 26 2020, 6:14 PM
0mp added a subscriber: 0mp.Nov 26 2020, 6:18 PM
0mp added inline comments.
usr.bin/iconv/iconv.1
112 ↗(On Diff #80030)

Does it render correctly? There should be no space between the filename and ":".

fernape updated this revision to Diff 80033.Nov 26 2020, 6:27 PM

Fix space between filename and ':'

Spotted by 0mp@

Harbormaster completed remote builds in B35056: Diff 80033.Nov 26 2020, 6:27 PM
0mp accepted this revision.Nov 26 2020, 6:47 PM

Looks good to me, although I'd probably replace ISO-8859-1 with UTF-8 to keep the example a bit more modern. ;)

Could you MFC this change?

Also, remember about the date bump.

Thanks!

This revision is now accepted and ready to land.Nov 26 2020, 6:47 PM
fernape removed a reviewer: 0mp.Nov 26 2020, 7:16 PM
fernape marked an inline comment as done.
In D27385#611796, @0mp wrote:

Looks good to me, although I'd probably replace ISO-8859-1 with UTF-8 to keep the example a bit more modern. ;)

OK, I'll change it at commit time if that is OK with you.

Could you MFC this change?

Sure, a couple of questions first :-)

  • Target branches are _both_ stable/11 and stable/12?
  • "MFC to" and "MFC after" should be filled right?
  • Do I need to specify the reason of the MFC? Something similar to what we do in ports when doing "blanket, runtime fix" or anything?

Also, remember about the date bump.

I will!

Thanks!

usr.bin/iconv/iconv.1
112 ↗(On Diff #80030)

(sigh) I didn't see that, sorry. The ratio of mistakes per changed byte in this review is really high :S

This revision now requires review to proceed.Nov 26 2020, 7:16 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 29 2020, 6:23 PM
Closed by commit rS368160: iconv(1): Add EXAMPLE (authored by fernape). · Explain Why
This revision was automatically updated to reflect the committed changes.
fernape marked an inline comment as done.
fernape added a commit: rS368160: iconv(1): Add EXAMPLE.
fernape added a comment.Nov 29 2020, 6:49 PM

Thanks for the review!

I'll merge this shortly.

fernape added a commit: rS368243: iconv(1): Add EXAMPLE.Dec 1 2020, 6:12 PM
fernape added a commit: rS368244: iconv(1): Add EXAMPLE.Dec 1 2020, 6:14 PM

Revision Contents
Changeset List

PathSize
head/
usr.bin/
iconv/
7 lines

Diff 80125

View Options

head/usr.bin/iconv/iconv.1

Loading...