Page MenuHomeFreeBSD

iconv(1): Add EXAMPLE
ClosedPublic

Authored by fernape on Nov 26 2020, 6:14 PM.

Details

Summary

Just a small example to show simple usage.

Test Plan
  • mandoc -Tlint clean
  • igor clean
  • aspell happy
  • man ./iconv.1 renders the page properly

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

0mp added inline comments.
usr.bin/iconv/iconv.1
112 ↗(On Diff #80030)

Does it render correctly? There should be no space between the filename and ":".

Fix space between filename and ':'

Spotted by 0mp@

Looks good to me, although I'd probably replace ISO-8859-1 with UTF-8 to keep the example a bit more modern. ;)

Could you MFC this change?

Also, remember about the date bump.

Thanks!

This revision is now accepted and ready to land.Nov 26 2020, 6:47 PM
fernape marked an inline comment as done.
In D27385#611796, @0mp wrote:

Looks good to me, although I'd probably replace ISO-8859-1 with UTF-8 to keep the example a bit more modern. ;)

OK, I'll change it at commit time if that is OK with you.

Could you MFC this change?

Sure, a couple of questions first :-)

  • Target branches are _both_ stable/11 and stable/12?
  • "MFC to" and "MFC after" should be filled right?
  • Do I need to specify the reason of the MFC? Something similar to what we do in ports when doing "blanket, runtime fix" or anything?

Also, remember about the date bump.

I will!

Thanks!

usr.bin/iconv/iconv.1
112 ↗(On Diff #80030)

(sigh) I didn't see that, sorry. The ratio of mistakes per changed byte in this review is really high :S

This revision now requires review to proceed.Nov 26 2020, 7:16 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 29 2020, 6:23 PM
Closed by commit rS368160: iconv(1): Add EXAMPLE (authored by fernape). · Explain Why
This revision was automatically updated to reflect the committed changes.
fernape marked an inline comment as done.

Thanks for the review!

I'll merge this shortly.