Differential D27367

Remove uses of CRIOGET in OCF tests after r368005.
ClosedPublic
Actions

Authored by jhb on Nov 25 2020, 1:13 AM.

Tags

None

Referenced Files

	F132285970: D27367.id79977.diff
	Wed, Oct 15, 1:01 PM

	F132285967: D27367.id79978.diff
	Wed, Oct 15, 1:01 PM

	Unknown Object (File)
	Wed, Oct 15, 2:05 AM

	Unknown Object (File)
	Wed, Oct 15, 2:05 AM

	Unknown Object (File)
	Wed, Oct 15, 2:05 AM

	Unknown Object (File)
	Tue, Oct 14, 5:11 PM

	Unknown Object (File)
	Sat, Sep 20, 3:14 PM

	Unknown Object (File)
	Sep 12 2025, 3:11 AM

Subscribers

Details

Reviewers

cem
jmg

Commits

rS368008: Remove uses of CRIOGET in OCF tests after r368005.

Test Plan

still need to actually test these

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Nov 25 2020, 1:13 AM

jhb created this revision.

Harbormaster completed remote builds in B35028: Diff 79977.Nov 25 2020, 1:13 AM

Passes running tests. I'm going to merge this to unbreak the build.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 25 2020, 1:31 AM

Closed by commit rS368008: Remove uses of CRIOGET in OCF tests after r368005. (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS368008: Remove uses of CRIOGET in OCF tests after r368005..

Herald added a reviewer: jmg. · View Herald TranscriptNov 25 2020, 1:31 AM

Herald added a subscriber: imp. · View Herald Transcript

markj added inline comments.Nov 25 2020, 1:36 AM

tools/tools/crypto/cryptokeytest.c
116 ↗	(On Diff #79977)	We leak the fd now.

Lgtm.

jhb added inline comments.Nov 25 2020, 9:58 PM

tools/tools/crypto/cryptokeytest.c
116 ↗	(On Diff #79977)	devcrypto() allocates a single static fd for /dev/crypto that it leaks until process exit by design. This just reuses that. I went for a smaller diff than replacing ioctl() calls, though perhaps there is only one ioctl() call so just using devcrypto() directly for the ioctl() would have been fine.

markj added inline comments.Nov 25 2020, 10:00 PM

tools/tools/crypto/cryptokeytest.c
116 ↗	(On Diff #79977)	Sorry, I missed that devcrypto() caches the open fd. I thought we were opening /dev/crypto anew upon each call.

Revision Contents
Changeset List

Path

Size

head/

tests/

sys/

opencrypto/

13 lines

13 lines

poly1305_test.c

13 lines

tools/

tools/

crypto/

cryptokeytest.c

5 lines

16 lines

Diff 79978

head/tests/sys/opencrypto/blake2_test.c

Loading...

head/tests/sys/opencrypto/cryptodev.py

Loading...

head/tests/sys/opencrypto/poly1305_test.c

Loading...

head/tools/tools/crypto/cryptokeytest.c

Loading...

head/tools/tools/crypto/cryptotest.c

Loading...