Page MenuHomeFreeBSD

Remove uses of CRIOGET in OCF tests after r368005.
ClosedPublic

Authored by jhb on Nov 25 2020, 1:13 AM.

Details

Test Plan
  • still need to actually test these

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Nov 25 2020, 1:13 AM
jhb created this revision.

Passes running tests. I'm going to merge this to unbreak the build.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 25 2020, 1:31 AM
This revision was automatically updated to reflect the committed changes.
tools/tools/crypto/cryptokeytest.c
116 ↗(On Diff #79977)

We leak the fd now.

tools/tools/crypto/cryptokeytest.c
116 ↗(On Diff #79977)

devcrypto() allocates a single static fd for /dev/crypto that it leaks until process exit by design. This just reuses that. I went for a smaller diff than replacing ioctl() calls, though perhaps there is only one ioctl() call so just using devcrypto() directly for the ioctl() would have been fine.

tools/tools/crypto/cryptokeytest.c
116 ↗(On Diff #79977)

Sorry, I missed that devcrypto() caches the open fd. I thought we were opening /dev/crypto anew upon each call.