Page MenuHomeFreeBSD
Differential D27350

pf tests: provoke tag hashing panic
ClosedPublic
Actions

Authored by kp on Nov 24 2020, 10:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 23, 2:30 AM
Unknown Object (File)
Tue, Oct 21, 1:44 PM
Unknown Object (File)
Tue, Oct 21, 1:55 AM
Unknown Object (File)
Mon, Oct 20, 4:20 PM
Unknown Object (File)
Sun, Oct 19, 5:56 AM
Unknown Object (File)
Sat, Oct 18, 10:44 PM
Unknown Object (File)
Sun, Oct 12, 8:17 AM
Unknown Object (File)
Oct 4 2025, 2:30 AM
View All 77 Files
Subscribers
farrokhi
imp
markj
melifaro

Details

Reviewers
markj
Group Reviewers
network
Commits
rS367990: pf tests: provoke tag hashing panic
Summary

Attempt to provoke the panic fixed in rXXXXX.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Nov 24 2020, 10:04 AM
Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptNov 24 2020, 10:04 AM
kp requested review of this revision.Nov 24 2020, 10:04 AM
Harbormaster completed remote builds in B34996: Diff 79925.Nov 24 2020, 10:04 AM
kp mentioned this in D27346: pf: Fix tag hashing.Nov 24 2020, 10:05 AM
markj added a subscriber: markj.Nov 24 2020, 2:11 PM
markj added inline comments.
tests/sys/netpfil/pf/ioctl/validation.c
819 ↗(On Diff #79925)

To provoke the panic you'd need a long tag name, so I'm not sure how this can accomplish that.

markj accepted this revision.Nov 24 2020, 2:35 PM
markj added inline comments.
tests/sys/netpfil/pf/ioctl/validation.c
819 ↗(On Diff #79925)

I see, match_tagname is full of garbage, rather than tagname.

This revision is now accepted and ready to land.Nov 24 2020, 2:35 PM
kp added inline comments.Nov 24 2020, 3:01 PM
tests/sys/netpfil/pf/ioctl/validation.c
819 ↗(On Diff #79925)

Yeah, there are a couple of fields that are passed through to tagname2hashindex().
Arguably this test should try all of them.

Closed by commit rS367990: pf tests: provoke tag hashing panic (authored by kp). · Explain WhyNov 24 2020, 5:33 PM
This revision was automatically updated to reflect the committed changes.
kp added a commit: rS367990: pf tests: provoke tag hashing panic.

Revision Contents
Changeset List

PathSize
head/
tests/
sys/
netpfil/
pf/
ioctl/
38 lines

Diff 79939

View Options

head/tests/sys/netpfil/pf/ioctl/validation.c

Loading...