Page MenuHomeFreeBSD

Update phabricator port
ClosedPublic

Authored by eadler on Jun 4 2015, 3:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 27, 6:27 PM
Unknown Object (File)
Tue, Jan 3, 5:57 AM
Unknown Object (File)
Dec 29 2022, 8:07 PM
Unknown Object (File)
Dec 27 2022, 4:16 PM
Unknown Object (File)
Dec 24 2022, 3:20 AM
Unknown Object (File)
Dec 10 2022, 1:00 AM
Unknown Object (File)
Dec 10 2022, 12:00 AM
Unknown Object (File)
Dec 9 2022, 11:37 PM
Subscribers

Details

Summary

this updates the phabricator port to the latest revision as of 2015-06-03.

Phabricator core moves at a fairly fast rate and upstream has already made breaking changes that result in old arcanist being broken.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

eadler retitled this revision from to Update phabricator port.
eadler updated this object.
eadler edited the test plan for this revision. (Show Details)

add libphutil; update arcanist to include version number change

koobs requested changes to this revision.Jun 4 2015, 4:37 AM
koobs edited edge metadata.
koobs added inline comments.
devel/arcanist/Makefile
5

devel php?

6

Why doesn't Mk/bsd.php.mk set this like Python? Eg:

PKGNAMEPREFIX=${PYTHON_PKGNAMEPREFIX}

Might be a good opportunity to add the following to bsd.php.mk

PHP_PKGNAMEPREFIX=<whatever>
11–12

Does a LICENSE_FILE exist in WRKSRC? If so add it here

devel/libphutil/Makefile
5

devel php?

11–12

LICENSE_FILE

devel/phabricator/Makefile
5

devel php

9

Upstream "short description" is:

Open source, software engineering platform
13

LICENSE_FILE

This revision now requires changes to proceed.Jun 4 2015, 4:37 AM

Also missing QA results:

  • poudriere
  • portlint

Please also update revision summary to include proposed commit log and itemized changes

I made some changes per your request

devel/arcanist/Makefile
5

php is not a category

6

I don't know but don't want to make this diff bigger than just updating / lint fixing the port.

11–12

good point; added.

eadler edited edge metadata.
eadler marked an inline comment as done.

per koobs

eadler edited edge metadata.
koobs edited edge metadata.

Changes LGTM. Can't 'approve' without QA results.

Over to you @eadler

This revision is now accepted and ready to land.Jun 4 2015, 5:15 AM

@koobs, don't have poudrie results due to it being broken on my VM; portlint is basically clean (with some minor nits fixed in this diff)

grembo edited edge metadata.

Are there any specific features or is this "only" about staying current/compatibility like you stated in the summary section?

eadler requested a review of this revision.Jun 5 2015, 2:23 AM
eadler edited edge metadata.

@grembo, any objections?

eadler added a reviewer: eadler.

woops, looks like I hit the wrong button; there are no new features in arcanist, its just about staying current. Phabricator changelog is too long to summarize though.

This revision is now accepted and ready to land.Jun 5 2015, 2:25 AM
This revision was automatically updated to reflect the committed changes.