Page MenuHomeFreeBSD
Differential D27300

Update dirdeps.mk et al to latest
ClosedPublic
Actions

Authored by sjg on Nov 20 2020, 9:38 PM.
Tags
None
Referenced Files
F105987459: D27300.diff
Mon, Dec 23, 12:41 PM
Unknown Object (File)
Tue, Dec 10, 5:23 AM
Unknown Object (File)
Sat, Dec 7, 7:35 AM
Unknown Object (File)
Wed, Nov 27, 5:17 PM
Unknown Object (File)
Mon, Nov 25, 12:21 PM
Unknown Object (File)
Sat, Nov 23, 5:51 PM
Unknown Object (File)
Sat, Nov 23, 1:15 PM
Unknown Object (File)
Nov 23 2024, 8:15 AM
View All Files
Subscribers
bdrewery
emaste
imp

Details

Reviewers
bdrewery
Commits
rS367999: Update dirdeps.mk et al to latest
Summary

Move some local tweaks to local.*.mk

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sjg created this revision.Nov 20 2020, 9:38 PM
Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptNov 20 2020, 9:38 PM
sjg requested review of this revision.Nov 20 2020, 9:38 PM
Harbormaster completed remote builds in B34935: Diff 79819.Nov 20 2020, 9:38 PM
sjg added a reviewer: bdrewery.Nov 20 2020, 9:40 PM
bdrewery requested changes to this revision.Nov 20 2020, 10:41 PM
bdrewery added inline comments.
share/mk/dirdeps.mk
69 ↗(On Diff #79819)

share/mk/local.meta.sys.mk and share/mk/bsd.init.mk reference these still.

share/mk/meta.autodep.mk
62–81 ↗(On Diff #79819)

What's going on with BUILD_AT_LEVEL0? The first check defaults to yes and only runs when yes. So removing the check makes sense. The second defaults to yes and compares to no, so now we're adding both yes and no behavior by removing it. Is that ok?

This revision now requires changes to proceed.Nov 20 2020, 10:41 PM
sjg updated this revision to Diff 79822.Nov 21 2020, 12:43 AM

remove refs to BUILD_AT_LEVEL0

Harbormaster completed remote builds in B34937: Diff 79822.Nov 21 2020, 12:44 AM
sjg marked an inline comment as done.Nov 21 2020, 12:48 AM
sjg added inline comments.
share/mk/dirdeps.mk
69 ↗(On Diff #79819)

removed. them

share/mk/meta.autodep.mk
62–81 ↗(On Diff #79819)

I'm removing it. It was originally a crutch to ease transition when share/mk wasn't ready.

sjg updated this revision to Diff 79825.Nov 21 2020, 2:37 AM
sjg marked an inline comment as done.

Grab LEVEL0_TARGETS from init.mk

Harbormaster completed remote builds in B34940: Diff 79825.Nov 21 2020, 2:38 AM
sjg updated this revision to Diff 79826.Nov 21 2020, 2:39 AM

Revert extra blank lines

Harbormaster completed remote builds in B34941: Diff 79826.Nov 21 2020, 2:40 AM
bdrewery accepted this revision.Nov 24 2020, 9:01 PM
This revision is now accepted and ready to land.Nov 24 2020, 9:01 PM
Closed by commit rS367999: Update dirdeps.mk et al to latest (authored by sjg). · Explain WhyNov 24 2020, 9:46 PM
This revision was automatically updated to reflect the committed changes.
sjg added a commit: rS367999: Update dirdeps.mk et al to latest.

Revision Contents
Changeset List

Diff 79951

View Options

head/share/mk/bsd.init.mk

Loading...
View Options

head/share/mk/dirdeps-options.mk

Loading...
View Options

head/share/mk/dirdeps-targets.mk

Loading...
View Options

head/share/mk/dirdeps.mk

Loading...
View Options

head/share/mk/gendirdeps.mk

Loading...
View Options

head/share/mk/local.autodep.mk

Loading...
View Options

head/share/mk/local.dirdeps.mk

Loading...
View Options

head/share/mk/local.gendirdeps.mk

Loading...
View Options

head/share/mk/local.meta.sys.mk

Loading...
View Options

head/share/mk/meta.autodep.mk

Loading...
View Options

head/share/mk/meta.stage.mk

Loading...
View Options

head/share/mk/meta.subdir.mk

Loading...
View Options

head/share/mk/meta.sys.mk

Loading...
View Options

head/share/mk/meta2deps.py

Loading...
View Options

head/share/mk/meta2deps.sh

Loading...