Little refactor to gefacl
ClosedPublic
Actions

Authored by arrowd on Nov 20 2020, 6:45 AM.

Details

Reviewers

markj
tsoome

Group Reviewers

Contributor Reviews (src)

Commits

rS367958: bin/setfacl: Little refactoring, no functional change.

Summary

The acl_from_stat function accepts a stat_t * argument, but only uses its st_mode field. There is no reason to pass the whole struct, so make it accept a mode_t and rename the function to acl_from_mode.

Linux has non-standard acl_from_mode function in its libacl, so naming the function this way may help discovering it during porting efforts.

Test Plan

Compiled, ran getfacl somefile and verified that the output is the same as before.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arrowd created this revision.Nov 20 2020, 6:45 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 20 2020, 6:45 AM

arrowd requested review of this revision.Nov 20 2020, 6:45 AM

Seems to make sense. As you hint about compatibility with linux version, does this function produce the same results as linux version does?

Seems reasonable to me.

This revision is now accepted and ready to land.Nov 23 2020, 1:48 PM

In D27292#610436, @tsoome wrote:

Seems to make sense. As you hint about compatibility with linux version, does this function produce the same results as linux version does?

I didn't try, but judging from http://git.savannah.nongnu.org/cgit/acl.git/tree/libacl/acl_from_mode.c it seem to work exactly the same way.

tsoome accepted this revision.Nov 23 2020, 4:22 PM

Closed by commit rS367958: bin/setfacl: Little refactoring, no functional change. (authored by arrowd). · Explain WhyNov 23 2020, 5:00 PM

This revision was automatically updated to reflect the committed changes.

arrowd added a commit: rS367958: bin/setfacl: Little refactoring, no functional change..