Page MenuHomeFreeBSD
Differential D27254

pf: Fix incorrect assertion
ClosedPublic
Actions

Authored by kp on Nov 17 2020, 4:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 8, 9:54 AM
Unknown Object (File)
Dec 25 2023, 5:08 PM
Unknown Object (File)
Dec 23 2023, 10:40 AM
Unknown Object (File)
Dec 13 2023, 4:02 AM
Unknown Object (File)
Nov 14 2023, 8:58 PM
Unknown Object (File)
Sep 2 2023, 8:03 PM
Unknown Object (File)
Sep 2 2023, 8:00 PM
Unknown Object (File)
Sep 2 2023, 7:56 PM
View All 20 Files
Subscribers
farrokhi
imp
melifaro

Details

Reviewers
None
Group Reviewers
network
Commits
rS367867: pf: Fix incorrect assertion
Summary

We never set PFRULE_RULESRCTRACK when calling pf_insert_src_node(). We
do set PFRULE_SRCTRACK, so update the assertion to match.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34857
Build 31881: arc lint + arc unit

Event Timeline

kp created this revision.Nov 17 2020, 4:29 PM
Herald added subscribers: melifaro, farrokhi. · View Herald TranscriptNov 17 2020, 4:29 PM
kp requested review of this revision.Nov 17 2020, 4:29 PM
Harbormaster completed remote builds in B34857: Diff 79663.Nov 17 2020, 4:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 20 2020, 10:08 AM
Closed by commit rS367867: pf: Fix incorrect assertion (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rS367867: pf: Fix incorrect assertion.
Herald added a subscriber: imp. · View Herald TranscriptNov 20 2020, 10:08 AM

Revision Contents
Changeset List

PathSize
sys/
netpfil/
pf/
2 lines

Diff 79663

View Options

sys/netpfil/pf/pf.c

Loading...