pf: Fix incorrect assertion
ClosedPublic
Actions

Authored by kp on Nov 17 2020, 4:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Oct 12, 3:51 PM

	Unknown Object (File)
	Tue, Sep 30, 11:20 PM

	Unknown Object (File)
	Tue, Sep 30, 3:17 AM

	Unknown Object (File)
	Wed, Sep 24, 1:53 PM

	Unknown Object (File)
	Aug 18 2025, 12:02 PM

	Unknown Object (File)
	Jun 26 2025, 9:50 PM

	Unknown Object (File)
	Jun 16 2025, 7:26 PM

	Unknown Object (File)
	Jun 16 2025, 4:02 PM

Subscribers

Details

Reviewers

None

Group Reviewers

network

Commits

rS367867: pf: Fix incorrect assertion

Summary

We never set PFRULE_RULESRCTRACK when calling pf_insert_src_node(). We
do set PFRULE_SRCTRACK, so update the assertion to match.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Nov 17 2020, 4:29 PM

Herald added subscribers: melifaro, farrokhi. · View Herald TranscriptNov 17 2020, 4:29 PM

kp requested review of this revision.Nov 17 2020, 4:29 PM

Harbormaster completed remote builds in B34857: Diff 79663.Nov 17 2020, 4:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 20 2020, 10:08 AM

Closed by commit rS367867: pf: Fix incorrect assertion (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rS367867: pf: Fix incorrect assertion.

Herald added a subscriber: imp. · View Herald TranscriptNov 20 2020, 10:08 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

netpfil/

pf/

pf.c

2 lines

Diff 79794

View Options

pf: Fix incorrect assertionClosedPublicActions