Add a guard for broken SUBDIR.${MK_FOO} use
ClosedPublic
Actions

Authored by brooks on Nov 13 2020, 10:36 PM.

Tags

None

Referenced Files

	F151806369: D27211.diff
	Fri, Apr 10, 7:35 PM

	Unknown Object (File)
	Tue, Apr 7, 7:38 AM

	Unknown Object (File)
	Sat, Mar 28, 11:29 AM

	Unknown Object (File)
	Fri, Mar 27, 12:07 PM

	Unknown Object (File)
	Wed, Mar 25, 6:02 AM

	Unknown Object (File)
	Mar 9 2026, 5:04 PM

	Unknown Object (File)
	Mar 9 2026, 2:27 PM

	Unknown Object (File)
	Mar 4 2026, 12:47 PM

View All Files

Subscribers

emaste

imp

Details

Reviewers

bdrewery
arichardson

Commits

rS367735: Add a guard for broken SUBDIR.${MK_FOO} use

Summary

Check for the variable SUBDIR. and error as it usually means someone
forgot to include src.opts.mk.

This guard from CheriBSD found the bug in D27210.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Nov 13 2020, 10:36 PM

Herald added a subscriber: emaste. · View Herald TranscriptNov 13 2020, 10:36 PM

brooks requested review of this revision.Nov 13 2020, 10:36 PM

Harbormaster completed remote builds in B34791: Diff 79528.Nov 13 2020, 10:36 PM

Brilliant!

This revision is now accepted and ready to land.Nov 13 2020, 10:56 PM

git blame points at https://github.com/CTSRD-CHERI/cheribsd/commit/4d2d3d6dc7e7e38ce6403654f0f998e79ca4e0c4

Looks like I forgot to create the upstream review.

Closed by commit rS367735: Add a guard for broken SUBDIR.${MK_FOO} use (authored by brooks). · Explain WhyNov 16 2020, 7:15 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS367735: Add a guard for broken SUBDIR.${MK_FOO} use.

Herald added a subscriber: imp. · View Herald TranscriptNov 16 2020, 7:15 PM

Revision Contents
Changeset List

Path

Size

head/

share/

mk/

bsd.subdir.mk

6 lines

Diff 79621

View Options

head/share/mk/bsd.subdir.mk

Add a guard for broken SUBDIR.${MK_FOO} useClosedPublicActions