uaudio: add sysctl hw.usb.uaudio.handle_hid to allow disabling HID volume keys support
ClosedPublic
Actions

Authored by val_packett.cool on Nov 11 2020, 5:55 PM.

Details

Reviewers

• hselasky
wulf

Group Reviewers

Contributor Reviews (src)

Commits

rS368212: MFC r367615:
rS368211: MFC r367615:
rS367615: Add a tunable sysctl, hw.usb.uaudio.handle_hid, to allow disabling the

Summary

The new iichid input stack can handle the volume keys on audio devices, which is preferred when something in the desktop environment reacts to them :) so it should be possible to disable uaudio's built-in handling.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

val_packett.cool created this revision.Nov 11 2020, 5:55 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 11 2020, 5:55 PM

val_packett.cool requested review of this revision.Nov 11 2020, 5:55 PM

• hselasky added inline comments.Nov 11 2020, 7:45 PM

sys/dev/sound/usb/uaudio.c
105	You nee "\| CTLFLAG_MPSAFE" here. You can also set the constant argument "1, " to zero. It is only used for read-only sysctls I believe.

val_packett.cool added inline comments.Nov 11 2020, 9:04 PM

sys/dev/sound/usb/uaudio.c
105	sysctl(9) says about `MPSAFE`: This should only be used for SYSCTL_PROC() entries Is it wrong?

val_packett.cool edited the summary of this revision. (Show Details)Nov 11 2020, 10:13 PM

Adding @wulf to answer that.

The new iichid input stack can handle the volume keys on audio devices, which is preferred when something in the desktop environment reacts to them :) so it should be possible to disable uaudio's built-in handling.

+1. Userland volume control is more flexible and allows some fancy stuff like onscreen volume change notification

wulf accepted this revision.Nov 12 2020, 12:02 AM

This revision is now accepted and ready to land.Nov 12 2020, 12:02 AM

• hselasky accepted this revision.Nov 12 2020, 9:15 AM

Closed by commit rS367615: Add a tunable sysctl, hw.usb.uaudio.handle_hid, to allow disabling the (authored by • hselasky). · Explain WhyNov 12 2020, 9:26 AM

This revision was automatically updated to reflect the committed changes.

• hselasky added a commit: rS367615: Add a tunable sysctl, hw.usb.uaudio.handle_hid, to allow disabling the.

• hselasky added a commit: rS368211: MFC r367615:.Dec 1 2020, 12:36 PM

• hselasky added a commit: rS368212: MFC r367615:.