Page MenuHomeFreeBSD

vt: fix window switching w.r.t. cngrab/cnungrab
ClosedPublic

Authored by kevans on Nov 6 2020, 3:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 20, 11:14 PM
Unknown Object (File)
Sun, Jun 16, 12:24 AM
Unknown Object (File)
May 14 2024, 5:55 AM
Unknown Object (File)
May 13 2024, 4:30 AM
Unknown Object (File)
Apr 21 2024, 8:19 AM
Unknown Object (File)
Apr 20 2024, 8:54 PM
Unknown Object (File)
Apr 20 2024, 6:39 PM
Unknown Object (File)
Mar 26 2024, 1:13 PM
Subscribers

Details

Summary

Noticed while investigating the situation that lead to D27109, vt(4) will switch away from the current window but never switch back if the console ends up being ungrabbed.

Resolve this by recording the active window in cngrab(), and restore it on the last cnungrab() if we actually switched away.

While I was hacking on this, I noticed that vt_allocate_keyboard will do a cnungrab/cngrab dance if it needs to. Yank out basically just the parts it needs and use those directly to avoid clobbering the pre-grab window state -- it just wants the keyboard restored.

Test Plan

Switch to ttyv1, break to debugger, continue; observe it switching back to a functional ttyv1.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable