Page MenuHomeFreeBSD

Optimize set_syscall_retval for riscv
ClosedPublic

Authored by trasz on Oct 28 2020, 7:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 6:39 PM
Unknown Object (File)
Thu, Nov 14, 3:29 PM
Unknown Object (File)
Thu, Nov 14, 2:05 AM
Unknown Object (File)
Oct 14 2024, 2:29 PM
Unknown Object (File)
Sep 30 2024, 2:54 AM
Unknown Object (File)
Sep 22 2024, 7:39 AM
Unknown Object (File)
Sep 19 2024, 9:52 PM
Unknown Object (File)
Sep 19 2024, 2:44 AM
Subscribers

Details

Summary

Optimize set_syscall_retval for riscv by predicting the return
value to be zero.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34448
Build 31550: arc lint + arc unit

Event Timeline

trasz requested review of this revision.Oct 28 2020, 7:43 PM
This revision is now accepted and ready to land.Oct 28 2020, 8:48 PM
kp added a subscriber: kp.

Do we see measurable performance improvements with this?

(Looking at the generated code it does seem to be better, but measurements would make me feel better.)

I wouldn’t expect any visible results. The syscall path overhead is still huge, and there’s not a single reason for it - it’s a “death by thousand cuts” situation, which needs to be resolved in small chunks, like this one.