xhci: Handle the case when MSI-X BAR is same as IO BAR.
ClosedPublic
Actions

Authored by kib on Oct 22 2020, 11:18 PM.

Details

Reviewers

• hselasky
jhb
emaste

Commits

rS366978: xhci: Handle the case when MSI-X BAR is the same as IO BAR.

Summary

PCIe allows for MSI-X BAR to be either dedicated, or MSI-X Table may be co-located in some functional BAR. In the later case xhci(4) is unable to allocate active resource for the table because BAR is already activated.

Handle it by checking for this special case, and not try to alloc resource if MSI-X BAR is IO.

Reported and tested by: emaste

Note. It seems that a similar issue exists in iflib.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Oct 22 2020, 11:18 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 22 2020, 11:18 PM

kib requested review of this revision.Oct 22 2020, 11:18 PM

Harbormaster completed remote builds in B34331: Diff 78621.Oct 22 2020, 11:18 PM

LGTM and confirm it fixes the "Unable to map MSI-X table" issue on the machine I'm testing on.

sys/dev/usb/controller/xhci_pci.c
288 ↗	(On Diff #78621)	While here, drop the extraneous space before `\n` perhaps?

This revision is now accepted and ready to land.Oct 22 2020, 11:44 PM

Looks good.

Closed by commit rS366978: xhci: Handle the case when MSI-X BAR is the same as IO BAR. (authored by kib). · Explain WhyOct 23 2020, 6:18 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rS366978: xhci: Handle the case when MSI-X BAR is the same as IO BAR..

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

usb/

controller/

xhci_pci.c

34 lines

Diff 78652

View Options

head/sys/dev/usb/controller/xhci_pci.c

xhci: Handle the case when MSI-X BAR is same as IO BAR.ClosedPublicActions