Page MenuHomeFreeBSD
Differential D26857

IOMMU quirks added
ClosedPublic
Actions

Authored by br on Oct 19 2020, 1:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 17, 4:57 PM
Unknown Object (File)
Fri, Oct 17, 8:24 AM
Unknown Object (File)
Thu, Oct 16, 10:41 PM
Unknown Object (File)
Thu, Oct 16, 10:41 PM
Unknown Object (File)
Thu, Oct 16, 10:41 PM
Unknown Object (File)
Thu, Oct 16, 10:41 PM
Unknown Object (File)
Thu, Oct 16, 1:56 PM
Unknown Object (File)
Sat, Oct 11, 5:58 AM
View All 82 Files
Subscribers
imp

Details

Reviewers
kib
mav
Commits
rS366863: Add IOMMU_BUSWIDE ahci quirk.
Summary

Add the Marvel SATA quirk.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br requested review of this revision.Oct 19 2020, 1:35 PM
br created this revision.
kib added a comment.Oct 19 2020, 1:56 PM

No, this should be in SATA driver.

br updated this revision to Diff 78433.Oct 19 2020, 3:27 PM

Move the quirk to ahci driver

kib added a reviewer: mav.Oct 19 2020, 3:44 PM
kib added inline comments.
sys/dev/ahci/ahci.h
628

This define should be updated as well.

br updated this revision to Diff 78439.Oct 19 2020, 3:59 PM

Update AHCI quirk bitstring

kib accepted this revision.Oct 19 2020, 4:54 PM
This revision is now accepted and ready to land.Oct 19 2020, 4:54 PM
mav added a comment.Oct 19 2020, 5:36 PM

I have no objections, but the link specified lead me to Linux' drivers/pci/quirks.c file, where I've found the same done for 12 different Marvell HBAs. Why not do the same?

br updated this revision to Diff 78456.Oct 19 2020, 7:03 PM

Add IOMMU quirks for all the devices listed in linux

This revision now requires review to proceed.Oct 19 2020, 7:03 PM
mav accepted this revision.Oct 19 2020, 8:22 PM

Thanks!

This revision is now accepted and ready to land.Oct 19 2020, 8:22 PM
Closed by commit rS366863: Add IOMMU_BUSWIDE ahci quirk. (authored by br). · Explain WhyOct 19 2020, 9:27 PM
This revision was automatically updated to reflect the committed changes.
br added a commit: rS366863: Add IOMMU_BUSWIDE ahci quirk..
Herald added a subscriber: imp. · View Herald TranscriptOct 19 2020, 9:27 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
ahci/
1 line
15 lines

Diff 78433

View Options

sys/dev/ahci/ahci.h

Loading...
View Options

sys/dev/ahci/ahci_pci.c

Loading...