Differential D26827

Fix sleepq_add panic happening with too wide net epoch.
ClosedPublic
Actions

Authored by melifaro on Oct 17 2020, 11:28 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 17, 11:05 AM

	Unknown Object (File)
	Tue, Dec 17, 3:25 AM

	Unknown Object (File)
	Wed, Dec 4, 10:39 PM

	Unknown Object (File)
	Wed, Nov 27, 12:59 AM

	Unknown Object (File)
	Oct 26 2024, 5:33 PM

	Unknown Object (File)
	Oct 26 2024, 5:33 PM

	Unknown Object (File)
	Oct 26 2024, 5:33 PM

	Unknown Object (File)
	Oct 26 2024, 5:33 PM

View All 60 Files

Subscribers

hsw_bitmark.com

Details

Reviewers

Group Reviewers

Commits

rS366795: Fix sleepq_add panic happening with too wide net epoch in mcast control.

Summary

Fix panic described in kern/250413 introduced by D25445.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

melifaro created this revision.Oct 17 2020, 11:28 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 17 2020, 11:28 AM

melifaro requested review of this revision.Oct 17 2020, 11:28 AM

Harbormaster completed remote builds in B34226: Diff 78344.Oct 17 2020, 11:28 AM

melifaro edited the summary of this revision. (Show Details)Oct 17 2020, 11:30 AM

melifaro added a reviewer: network.

melifaro added a subscriber: kib.

It seems the only solution here is taking ifnet reference. I'm not sure about PCB, probably it can not disappear here.

sys/netinet/in_mcast.c
2087 ↗	(On Diff #78344)	IN_MULTI_LOCK() is sx lock, so you still can sleep while in epoch.

Reflect ae@ comments.

Harbormaster completed remote builds in B34232: Diff 78354.Oct 17 2020, 4:22 PM

ae accepted this revision.Oct 17 2020, 5:01 PM

This revision is now accepted and ready to land.Oct 17 2020, 5:01 PM

Closed by commit rS366795: Fix sleepq_add panic happening with too wide net epoch in mcast control. (authored by melifaro). · Explain WhyOct 17 2020, 8:33 PM

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rS366795: Fix sleepq_add panic happening with too wide net epoch in mcast control..

kib added inline comments.Oct 18 2020, 1:22 AM

head/sys/netinet/in_mcast.c
2085	I believe it would be not too hard to move this EXIT to before corresponding breaks inside switch. Current structure where ENTER is done inside switch, and you expect all cases escape with epoch entered, is too weird/fragile.

hsw_bitmark.com added a subscriber: hsw_bitmark.com.Oct 18 2020, 2:53 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

32 lines

Diff 78366

head/sys/netinet/in_mcast.c

Loading...