Page MenuHomeFreeBSD

Makefile: re-wordsmith the blurb about xtoolchain ports
ClosedPublic

Authored by kevans on Oct 16 2020, 5:47 PM.
Tags
None
Referenced Files
F165324920: D26820.id79551.diff
Fri, Aug 7, 3:53 PM
F165305940: D26820.id78324.diff
Fri, Aug 7, 1:24 PM
Unknown Object (File)
Thu, Aug 6, 11:13 AM
Unknown Object (File)
Wed, Aug 5, 5:32 AM
Unknown Object (File)
Tue, Jul 21, 12:37 AM
Unknown Object (File)
Sat, Jul 18, 8:09 AM
Unknown Object (File)
Jul 6 2026, 5:03 AM
Unknown Object (File)
Jul 5 2026, 3:24 PM
Subscribers

Details

Summary

The new version only includes a specific version once, and uses that that's currently advised by tinderbox: -gcc6.

It also advises just installing the pkg, but mentions in a side-note at the end where to find the source in the ports tree.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Seems good to me, though maybe N would be better than X to avoid confusion with the X in xtoolchain leading people to think gccX means a cross GCC if they don't bother looking too closely at the example? That or change "xtoolchain" to "cross toolchain" ("cross-toolchain"?), which also nicely matches CROSS_TOOLCHAIN.

Seems good to me, though maybe N would be better than X to avoid confusion with the X in xtoolchain leading people to think gccX means a cross GCC if they don't bother looking too closely at the example? That or change "xtoolchain" to "cross toolchain" ("cross-toolchain"?), which also nicely matches CROSS_TOOLCHAIN.

I'm tempted to do both, in case someone tries to make the logical leap from cross -> X anyways. Writing 'xtoolchain' was kind of just habit from the old ports that should be retired, and we probably shouldn't accidentally draw someone towards those ones.

+1 to the X -> N and xtoolchain -> "cross toolchain" changes.

Makefile
100 โ†—(On Diff #78324)
kevans marked an inline comment as done.

Incorporate feedback

One minor change but otherwise ๐Ÿ‘.

Makefile
93 โ†—(On Diff #78326)
This revision is now accepted and ready to land.Oct 16 2020, 6:27 PM
Makefile
93 โ†—(On Diff #78326)

I will fix this one pre-commit, thanks :)