Page MenuHomeFreeBSD
Differential D26805

geom_ctl.c: remove unused header files
ClosedPublic
Actions

Authored by rew on Oct 15 2020, 8:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 16, 7:53 PM
Unknown Object (File)
Sun, Sep 13, 3:35 PM
Unknown Object (File)
Fri, Sep 11, 6:28 PM
Unknown Object (File)
Sun, Sep 6, 2:38 AM
Unknown Object (File)
Sat, Sep 5, 3:36 AM
Unknown Object (File)
Tue, Aug 25, 9:20 PM
Unknown Object (File)
Mon, Aug 24, 6:04 AM
Unknown Object (File)
Aug 13 2026, 6:52 PM
View All Files
Subscribers
imp

Details

Reviewers
kevans
allanjude
phk
Commits
rS366903: geom_ctl.c: remove stale header files
Summary

remove 'sys/sysctl.h', it was a duplicate and no sysctl functionality is used
in geom_ctl.c. The duplicate here is how I wound up looking at the rest of the
header files.

remove 'opt_geom.h', geom_ctl.c doesn't use any kernel options.

remove 'sys/bio.h', requirements for bio moved out in r112534.

remove 'sys/lock.h' and 'sys/mutex.h', looks like the last thing that required
these headers were DROP_GIANT and PICKUP_GIANT, which were removed in
r115624.

It also appears that geom_ctl.c doesn't require anything from 'sys/disk.h' and
'sys/kernel.h'.

unless I'm missing something glaringly obvious..

Test Plan

rm -rf /usr/obj/*
make kernel-toolchain
make buildkernel

compiles on amd64

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rew created this revision.Oct 15 2020, 8:04 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 15 2020, 8:04 PM
rew requested review of this revision.Oct 15 2020, 8:04 PM
Harbormaster completed remote builds in B34197: Diff 78283.Oct 15 2020, 8:04 PM
phk accepted this revision.Oct 19 2020, 10:13 AM

Nice cleanup!

If it compiles, I see no problem with committing this.

This revision is now accepted and ready to land.Oct 19 2020, 10:13 AM
kevans accepted this revision.EditedOct 19 2020, 2:48 PM

LGTM.

Approved by: kevans (mentor)

(ninja edit... sorry, too much ports work lately)

Closed by commit rS366903: geom_ctl.c: remove stale header files (authored by rew). · Explain WhyOct 20 2020, 8:59 PM
This revision was automatically updated to reflect the committed changes.
rew added a commit: rS366903: geom_ctl.c: remove stale header files.

Revision Contents
Changeset List

PathSize
head/
sys/
geom/
10 lines

Diff 78520

View Options

head/sys/geom/geom_ctl.c

Loading...