Page MenuHomeFreeBSD

geom_ctl.c: remove unused header files
ClosedPublic

Authored by rew on Oct 15 2020, 8:04 PM.

Details

Summary

remove 'sys/sysctl.h', it was a duplicate and no sysctl functionality is used
in geom_ctl.c. The duplicate here is how I wound up looking at the rest of the
header files.

remove 'opt_geom.h', geom_ctl.c doesn't use any kernel options.

remove 'sys/bio.h', requirements for bio moved out in r112534.

remove 'sys/lock.h' and 'sys/mutex.h', looks like the last thing that required
these headers were DROP_GIANT and PICKUP_GIANT, which were removed in
r115624.

It also appears that geom_ctl.c doesn't require anything from 'sys/disk.h' and
'sys/kernel.h'.

unless I'm missing something glaringly obvious..

Test Plan

rm -rf /usr/obj/*
make kernel-toolchain
make buildkernel

compiles on amd64

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rew requested review of this revision.Oct 15 2020, 8:04 PM

Nice cleanup!

If it compiles, I see no problem with committing this.

This revision is now accepted and ready to land.Oct 19 2020, 10:13 AM

LGTM.

Approved by: kevans (mentor)

(ninja edit... sorry, too much ports work lately)

This revision was automatically updated to reflect the committed changes.