Fix pipe handling in unrelated debugger test.
ClosedPublic
Actions

Authored by jhb on May 30 2015, 6:51 PM.

Details

Reviewers

• rodrigc
kib
ngie

Commits

rS283836: Consistently only use one end of the pipe in the parent and debugger

Summary

Consistently only use one end of the pipe in the parent and debugger
processes and do not rely on EOF due to a close() in the debugger.

PR: 200489

Test Plan

Run the unrelated debugger test in a loop. It used to fail in a few iterations. It has no run in a constant loop for several minutes without failing.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb updated this revision to Diff 5807.May 30 2015, 6:51 PM

jhb retitled this revision from to Fix pipe handling in unrelated debugger test..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added reviewers: kib, ngie.

Herald added a subscriber: imp. · View Herald TranscriptMay 30 2015, 6:51 PM

kib accepted this revision.May 30 2015, 7:23 PM

kib edited edge metadata.

This revision is now accepted and ready to land.May 30 2015, 7:23 PM

Thanks :)!

• rodrigc accepted this revision.May 31 2015, 8:02 AM

• rodrigc added a reviewer: • rodrigc.

Closed by commit rS283836: Consistently only use one end of the pipe in the parent and debugger (authored by jhb). · Explain WhyMay 31 2015, 7:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

tests/

sys/

kern/

ptrace_test.c

8 lines

Diff 5844

View Options

head/tests/sys/kern/ptrace_test.c

Fix pipe handling in unrelated debugger test.ClosedPublicActions