Page MenuHomeFreeBSD
Differential D2670

[Mk/Scripts/qa.sh] add blacklist of files which are not intended to be executed
AbandonedPublic
Actions

Authored by AMDmi3 on May 29 2015, 3:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 16 2026, 10:04 PM
Unknown Object (File)
Jan 16 2026, 4:03 PM
Unknown Object (File)
Jan 16 2026, 3:21 PM
Unknown Object (File)
Jan 16 2026, 12:39 PM
Unknown Object (File)
Jan 16 2026, 12:25 AM
Unknown Object (File)
Jan 15 2026, 9:45 PM
Unknown Object (File)
Jan 15 2026, 9:17 PM
Unknown Object (File)
Jan 15 2026, 4:43 PM
View All Files
Subscribers
eadler

Details

Reviewers
swills
bapt
mat
Group Reviewers
portmgr
Summary

This will allow to run shebang test on whole ${PREFIX} after some testing

Sort shebang list along the way

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

AMDmi3 updated this revision to Diff 5775.May 29 2015, 3:30 PM
AMDmi3 retitled this revision from to [Mk/Scripts/qa.sh] add /usr/bin/false to allowed shebangs.
AMDmi3 updated this object.
AMDmi3 edited the test plan for this revision. (Show Details)
AMDmi3 added reviewers: mat, bdrewery, bapt.
Herald added a reviewer: portmgr. · View Herald TranscriptMay 29 2015, 3:30 PM
AMDmi3 added a reviewer: swills.May 29 2015, 3:32 PM
eadler accepted this revision.May 29 2015, 3:38 PM
eadler added a reviewer: eadler.
eadler added a subscriber: eadler.

LGTM; obviously wait for portmgr to approve.

mat requested changes to this revision.May 29 2015, 8:20 PM
mat edited edge metadata.

No. Nothing ever runs /usr/bin/false. (You can sort the thing if you like, but don't add /usr/bin/false.)

This revision now requires changes to proceed.May 29 2015, 8:20 PM
bdrewery requested changes to this revision.May 29 2015, 8:30 PM
bdrewery edited edge metadata.

/bin/false is just busy work. Please don't waste my time or contributors time. It adds more maintenance cost for 0 benefit.

eadler resigned from this revision.May 29 2015, 8:35 PM
eadler removed a reviewer: eadler.

apperently I missed something

AMDmi3 updated this revision to Diff 5781.May 29 2015, 8:46 PM
AMDmi3 edited edge metadata.

Aight. Then add a blacklist of file extensions into a shebang check. Still sort interpreter list.

AMDmi3 updated this revision to Diff 5782.May 29 2015, 8:48 PM
AMDmi3 edited edge metadata.

Fix style

AMDmi3 updated this revision to Diff 5783.May 29 2015, 8:49 PM

Fix style some more

mat added inline comments.May 29 2015, 8:52 PM
Mk/Scripts/qa.sh
37

no need to for one basename fork call for each file, using some sh like ${f##*/} should be enough.

AMDmi3 updated this revision to Diff 5785.May 29 2015, 9:01 PM

Use more effective sh code

AMDmi3 marked an inline comment as done.May 29 2015, 9:02 PM
bdrewery resigned from this revision.May 29 2015, 9:05 PM
bdrewery removed a reviewer: bdrewery.

I just noticed the original patch was ignoring /usr/bin/false. That's seems like a good thing. Some IRC convo bled into here.

AMDmi3 updated this revision to Diff 5786.May 29 2015, 9:25 PM

interp actually belongs to the second case

AMDmi3 updated this revision to Diff 5938.Jun 4 2015, 10:04 AM

Add *.txt to blacklist

AMDmi3 retitled this revision from [Mk/Scripts/qa.sh] add /usr/bin/false to allowed shebangs to [Mk/Scripts/qa.sh] add blacklist of files which are not intended to be executed.Jun 4 2015, 10:05 AM
AMDmi3 updated this object.
bapt accepted this revision.Jun 4 2015, 11:15 AM
bapt edited edge metadata.
AMDmi3 mentioned this in rP388526: - Add blacklist of files which are not intended to be executed to shebang test.Jun 4 2015, 11:37 AM
AMDmi3 abandoned this revision.Jun 4 2015, 11:42 AM

Committed. Not sure why while this differential rev can't be closed properly.

Revision Contents
Changeset List

PathSize
Mk/
Scripts/
16 lines

Diff 5938

View Options

Mk/Scripts/qa.sh

Loading...