Page MenuHomeFreeBSD

Remove yet another useless assignment
ClosedPublic

Authored by trasz on Oct 6 2020, 5:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 27, 3:26 AM
Unknown Object (File)
Wed, Nov 26, 1:03 AM
Unknown Object (File)
Tue, Nov 25, 8:12 PM
Unknown Object (File)
Sun, Nov 23, 2:47 PM
Unknown Object (File)
Thu, Nov 20, 7:13 PM
Unknown Object (File)
Thu, Nov 20, 6:26 PM
Unknown Object (File)
Thu, Nov 20, 6:17 PM
Unknown Object (File)
Thu, Nov 20, 6:06 PM
Subscribers

Details

Summary

Remove yet another useless assignment, adding a KASSERT just in case.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34033
Build 31220: arc lint + arc unit

Event Timeline

trasz requested review of this revision.Oct 6 2020, 5:56 PM
This revision is now accepted and ready to land.Oct 7 2020, 12:20 PM
arichardson added inline comments.
sys/riscv/riscv/trap.c
317

Since frame is already stored to td->td_frame, we could drop this argument? And also the mv a0, sp in cpu_exception_handler_user ?
And then just add a struct trapframe *frame = td->td_frame and drop the assert?

sys/riscv/riscv/trap.c
317

That's the plan. I'm just doing this one step at a time, to make it easier to bisect, should it become necessary.