Page MenuHomeFreeBSD

Remove yet another useless assignment
ClosedPublic

Authored by trasz on Oct 6 2020, 5:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 1, 5:13 PM
Unknown Object (File)
Sun, Feb 23, 8:19 AM
Unknown Object (File)
Sat, Feb 22, 6:33 PM
Unknown Object (File)
Sat, Feb 22, 4:38 PM
Unknown Object (File)
Sat, Feb 22, 2:46 PM
Unknown Object (File)
Sat, Feb 22, 1:52 PM
Unknown Object (File)
Tue, Feb 18, 6:20 PM
Unknown Object (File)
Mon, Feb 17, 6:48 AM
Subscribers

Details

Summary

Remove yet another useless assignment, adding a KASSERT just in case.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz requested review of this revision.Oct 6 2020, 5:56 PM
This revision is now accepted and ready to land.Oct 7 2020, 12:20 PM
arichardson added inline comments.
sys/riscv/riscv/trap.c
317 ↗(On Diff #77970)

Since frame is already stored to td->td_frame, we could drop this argument? And also the mv a0, sp in cpu_exception_handler_user ?
And then just add a struct trapframe *frame = td->td_frame and drop the assert?

sys/riscv/riscv/trap.c
317 ↗(On Diff #77970)

That's the plan. I'm just doing this one step at a time, to make it easier to bisect, should it become necessary.