Page MenuHomeFreeBSD

Remove yet another useless assignment
ClosedPublic

Authored by trasz on Oct 6 2020, 5:56 PM.
Tags
None
Referenced Files
F135341937: D26698.id77947.diff
Sat, Nov 8, 10:42 PM
Unknown Object (File)
Wed, Nov 5, 4:50 AM
Unknown Object (File)
Fri, Oct 31, 4:10 AM
Unknown Object (File)
Thu, Oct 23, 3:36 PM
Unknown Object (File)
Wed, Oct 22, 10:45 PM
Unknown Object (File)
Wed, Oct 22, 10:45 PM
Unknown Object (File)
Wed, Oct 22, 10:45 PM
Unknown Object (File)
Wed, Oct 22, 2:00 PM
Subscribers

Details

Summary

Remove yet another useless assignment, adding a KASSERT just in case.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz requested review of this revision.Oct 6 2020, 5:56 PM
This revision is now accepted and ready to land.Oct 7 2020, 12:20 PM
arichardson added inline comments.
sys/riscv/riscv/trap.c
317 ↗(On Diff #77970)

Since frame is already stored to td->td_frame, we could drop this argument? And also the mv a0, sp in cpu_exception_handler_user ?
And then just add a struct trapframe *frame = td->td_frame and drop the assert?

sys/riscv/riscv/trap.c
317 ↗(On Diff #77970)

That's the plan. I'm just doing this one step at a time, to make it easier to bisect, should it become necessary.