Page MenuHomeFreeBSD

Remove yet another useless assignment
ClosedPublic

Authored by trasz on Oct 6 2020, 5:56 PM.
Tags
None
Referenced Files
F148974514: D26698.id77970.diff
Sat, Mar 21, 11:06 AM
Unknown Object (File)
Fri, Mar 20, 4:26 AM
Unknown Object (File)
Thu, Mar 19, 12:07 AM
Unknown Object (File)
Tue, Mar 17, 2:32 PM
Unknown Object (File)
Tue, Mar 17, 7:23 AM
Unknown Object (File)
Tue, Mar 17, 5:08 AM
Unknown Object (File)
Tue, Mar 17, 3:25 AM
Unknown Object (File)
Sun, Feb 22, 9:32 AM
Subscribers

Details

Summary

Remove yet another useless assignment, adding a KASSERT just in case.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz requested review of this revision.Oct 6 2020, 5:56 PM
This revision is now accepted and ready to land.Oct 7 2020, 12:20 PM
arichardson added inline comments.
sys/riscv/riscv/trap.c
317 ↗(On Diff #77970)

Since frame is already stored to td->td_frame, we could drop this argument? And also the mv a0, sp in cpu_exception_handler_user ?
And then just add a struct trapframe *frame = td->td_frame and drop the assert?

sys/riscv/riscv/trap.c
317 ↗(On Diff #77970)

That's the plan. I'm just doing this one step at a time, to make it easier to bisect, should it become necessary.