Page MenuHomeFreeBSD
Differential D26649

Drop a useless assignment, and add a KASSERT to make sure it really was useless.
ClosedPublic
Actions

Authored by trasz on Oct 3 2020, 3:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 1, 8:06 PM
Unknown Object (File)
Sat, Nov 1, 10:55 AM
Unknown Object (File)
Wed, Oct 29, 10:22 PM
Unknown Object (File)
Mon, Oct 27, 11:55 PM
Unknown Object (File)
Tue, Oct 14, 4:10 PM
Unknown Object (File)
Tue, Oct 14, 4:10 PM
Unknown Object (File)
Tue, Oct 14, 4:10 PM
Unknown Object (File)
Tue, Oct 14, 3:11 AM
View All 81 Files
Subscribers
imp
jhb
nick

Details

Reviewers
jhb
Group Reviewers
riscv
Commits
rS366454: Drop useless assignment, and add a KASSERT to make sure it really was useless.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33964
Build 31157: arc lint + arc unit

Event Timeline

trasz created this revision.Oct 3 2020, 3:42 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 3 2020, 3:42 PM
trasz requested review of this revision.Oct 3 2020, 3:42 PM
Harbormaster completed remote builds in B33964: Diff 77816.Oct 3 2020, 3:42 PM
trasz added a reviewer: riscv.Oct 3 2020, 3:42 PM
nick added a subscriber: nick.Oct 5 2020, 4:13 AM

Looks good to me.

jhb accepted this revision.Oct 5 2020, 5:48 PM
jhb added a subscriber: jhb.

It was nice as documentation, but the kassert is equally fine for that purpose. I would echo Jess in that arm64 probably should be similarly updated.

This revision is now accepted and ready to land.Oct 5 2020, 5:48 PM
Closed by commit rS366454: Drop useless assignment, and add a KASSERT to make sure it really was useless. (authored by trasz). · Explain WhyOct 5 2020, 6:42 PM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rS366454: Drop useless assignment, and add a KASSERT to make sure it really was useless..
trasz added a comment.Oct 5 2020, 6:42 PM

I don't see a similar assignment for arm64, though.

Revision Contents
Changeset List

PathSize
sys/
riscv/
riscv/
4 lines

Diff 77816

View Options

sys/riscv/riscv/trap.c

Loading...