Drop a useless assignment, and add a KASSERT to make sure it really was useless.
ClosedPublic
Actions

Authored by trasz on Oct 3 2020, 3:42 PM.

Tags

None

Referenced Files

	F161649892: D26649.diff
	Sun, Jul 5, 2:42 PM

	Unknown Object (File)
	Tue, Jun 30, 4:37 AM

	Unknown Object (File)
	Sat, Jun 27, 3:00 PM

	Unknown Object (File)
	Sat, Jun 20, 5:38 PM

	Unknown Object (File)
	Mon, Jun 15, 2:59 AM

	Unknown Object (File)
	Sat, Jun 13, 2:52 AM

	Unknown Object (File)
	Thu, Jun 11, 4:49 AM

	Unknown Object (File)
	Thu, Jun 11, 3:28 AM

Subscribers

Details

Reviewers

jhb

Group Reviewers

riscv

Commits

rS366454: Drop useless assignment, and add a KASSERT to make sure it really was useless.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Oct 3 2020, 3:42 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 3 2020, 3:42 PM

trasz requested review of this revision.Oct 3 2020, 3:42 PM

Harbormaster completed remote builds in B33964: Diff 77816.Oct 3 2020, 3:42 PM

trasz added a reviewer: riscv.Oct 3 2020, 3:42 PM

Looks good to me.

It was nice as documentation, but the kassert is equally fine for that purpose. I would echo Jess in that arm64 probably should be similarly updated.

This revision is now accepted and ready to land.Oct 5 2020, 5:48 PM

Closed by commit rS366454: Drop useless assignment, and add a KASSERT to make sure it really was useless. (authored by trasz). · Explain WhyOct 5 2020, 6:42 PM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS366454: Drop useless assignment, and add a KASSERT to make sure it really was useless..

I don't see a similar assignment for arm64, though.

Revision Contents
Changeset List

Path

Size

head/

sys/

riscv/

trap.c

4 lines

Diff 77908

View Options

head/sys/riscv/riscv/trap.c

Drop a useless assignment, and add a KASSERT to make sure it really was useless.ClosedPublicActions