Page MenuHomeFreeBSD

Only clear TDP_NERRNO when needed
ClosedPublic

Authored by trasz on Sep 30 2020, 7:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 26 2024, 2:24 PM
Unknown Object (File)
Oct 26 2024, 2:24 PM
Unknown Object (File)
Oct 26 2024, 2:24 PM
Unknown Object (File)
Oct 26 2024, 2:04 PM
Unknown Object (File)
Oct 1 2024, 3:23 PM
Unknown Object (File)
Oct 1 2024, 5:45 AM
Unknown Object (File)
Sep 22 2024, 8:44 PM
Unknown Object (File)
Sep 22 2024, 8:44 PM
Subscribers

Details

Summary

Only clear TDP_NERRNO when needed, ie when it's previously been set.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz requested review of this revision.Sep 30 2020, 7:07 PM
This revision is now accepted and ready to land.Sep 30 2020, 7:13 PM

this adds a branch which likely pessimizes the code

In D26612#592862, @mjg wrote:

this adds a branch which likely pessimizes the code

The branch is already there, you had to check td_pflags anyway. Not to mention that previously the branch was statically mispredicted (the common case is for (td_pflags & TDP_NERRNO) to be 0.