Page MenuHomeFreeBSD

libgssapi: modernize static string array use
ClosedPublic

Authored by brooks on Sep 29 2020, 8:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 6:47 PM
Unknown Object (File)
Wed, Oct 15, 6:47 PM
Unknown Object (File)
Wed, Oct 15, 6:47 PM
Unknown Object (File)
Wed, Oct 15, 8:21 AM
Unknown Object (File)
Aug 14 2025, 8:54 PM
Unknown Object (File)
Aug 7 2025, 10:13 PM
Unknown Object (File)
Aug 2 2025, 5:07 AM
Unknown Object (File)
Jul 27 2025, 6:42 AM
Subscribers

Details

Summary

Use designated initializers to document positions in the arrays rather
than requiring counting. Use nitems() rather than rolling it by hand to
count elements.

Also, passify a Clang 12 warning about suspcious string concatenation
within an array initializer by adding parentheses.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.
emaste added inline comments.
lib/libgssapi/gss_display_status.c
134 ↗(On Diff #77647)

If I were king of style(9) I would take an over-80-cols line vs relying on string concatenation; parens here make me stop and think for a second before accepting that the meaning is clear. Since I'm not the king of style, no objection.

This revision is now accepted and ready to land.Sep 29 2020, 9:56 PM
This revision was automatically updated to reflect the committed changes.