Simplify check for non-dumpable objects
ClosedPublic
Actions

Authored by markj on Sep 29 2020, 6:40 PM.

Details

Reviewers

alc
kib
dougm

Commits

rS366367: Simplify the check for non-dumpable VM object types

Summary

OBJT_DEFAULT, _SWAP, _VNODE and _PHYS is exactly the set of
non-fictitious object types, so just check OBJ_FICTITIOUS.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj requested review of this revision.Sep 29 2020, 6:40 PM

markj created this revision.

Harbormaster completed remote builds in B33879: Diff 77640.Sep 29 2020, 6:40 PM

markj added reviewers: alc, kib, dougm.Sep 29 2020, 6:41 PM

alc accepted this revision.Sep 29 2020, 6:44 PM

This revision is now accepted and ready to land.Sep 29 2020, 6:44 PM

dougm accepted this revision.Sep 29 2020, 7:07 PM

dougm added inline comments.

sys/kern/imgact_elf.c
1802 ↗	(On Diff #77640)	This is a change for object->type == OBJT_DEAD. Perhaps that's not a problem. I'll trust that it's not.

kib accepted this revision.Sep 29 2020, 7:59 PM

markj added inline comments.Sep 29 2020, 8:26 PM

sys/kern/imgact_elf.c
1802 ↗	(On Diff #77640)	I don't think it is. Even if the backing object isn't dead here, it could become so later on, so that case has to be handled.

Closed by commit rS366367: Simplify the check for non-dumpable VM object types (authored by markj). · Explain WhyOct 2 2020, 5:49 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rS366367: Simplify the check for non-dumpable VM object types.

Herald added a subscriber: imp. · View Herald TranscriptOct 2 2020, 5:49 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

imgact_elf.c

6 lines

Diff 77788

View Options

head/sys/kern/imgact_elf.c

Simplify check for non-dumpable objectsClosedPublicActions