Page MenuHomeFreeBSD

ccr: Disable requests on port 1 when needed to workaround a firmware bug.
ClosedPublic

Authored by jhb on Sep 28 2020, 8:17 PM.

Details

Summary

Completions for crypto requests on port 1 can sometimes return a stale
cookie value due to a firmware bug. Disable requests on port 1 by
default on affected firmware.

Test Plan
  • was able to reproduce a panic when sending traffic over the second port of a T6 when port 1 was used for crypto requests

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Sep 28 2020, 8:17 PM
jhb retitled this revision from Only enable port 0 by default. to ccr: Only enable port 0 by default..Mar 9 2021, 9:55 PM
jhb edited the summary of this revision. (Show Details)
np requested changes to this revision.Mar 10 2021, 5:46 AM
np added inline comments.
sys/dev/cxgbe/crypto/t4_crypto.c
2161
This revision now requires changes to proceed.Mar 10 2021, 5:46 AM
sys/dev/cxgbe/crypto/t4_crypto.c
2156–2165

Comment needs to be updated.

jhb edited the summary of this revision. (Show Details)
  • Update comment.
jhb retitled this revision from ccr: Only enable port 0 by default. to ccr: Disable requests on port 1 when needed to workaround a firmware bug..Mar 11 2021, 1:20 AM
jhb edited the summary of this revision. (Show Details)
jhb edited the summary of this revision. (Show Details)
  • Make the disable conditional on the firmware version.
This revision is now accepted and ready to land.Mar 11 2021, 8:13 PM