www/chromium: Make online detection always positive
ClosedPublic
Actions

Authored by khng on Sep 20 2020, 9:37 AM.

Details

Reviewers

jrm
lwhsu

Commits

rP557055: www/chromium: Synchronize with HEAD
rP555115: www/chromium: Make online detection always positive

Summary

navigator.onLine is currently broken in www/chromium. This change introduce a
workaround that always return positive for online detection.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 33664
Build 30904: arc lint + arc unit

Event Timeline

khng requested review of this revision.Sep 20 2020, 9:37 AM

khng created this revision.

Harbormaster completed remote builds in B33664: Diff 77246.Sep 20 2020, 9:37 AM

khng edited the summary of this revision. (Show Details)Sep 20 2020, 2:30 PM

khng edited the summary of this revision. (Show Details)Sep 20 2020, 2:34 PM

Thanks for this. We are working through an update now and will get to this once that update is complete.

Seems like it's fixed by ports.

Eh, seems the problem still persists on 85.0.4183.121_1

This revision was not accepted when it landed; it landed in state Needs Review.Nov 14 2020, 3:08 PM

Closed by commit rP555115: www/chromium: Make online detection always positive (authored by jrm). · Explain Why

This revision was automatically updated to reflect the committed changes.

jrm added a commit: rP555115: www/chromium: Make online detection always positive.

rene added a commit: rP557055: www/chromium: Synchronize with HEAD.Dec 7 2020, 10:19 AM

Revision Contents
Changeset List

Path

Size

www/

chromium/

files/

patch-net_base_network__change__notifier.cc

18 lines

Diff 77246

View Options

www/chromium/files/patch-net_base_networkchangenotifier.cc

www/chromium: Make online detection always positiveClosedPublicActions